Skip to content

Comments

Add agent-mode tip for enabling agentic browser integration#297026

Merged
meganrogge merged 7 commits intomainfrom
copilot/add-tip-agentic-integration
Feb 23, 2026
Merged

Add agent-mode tip for enabling agentic browser integration#297026
meganrogge merged 7 commits intomainfrom
copilot/add-tip-agentic-integration

Conversation

Copy link
Contributor

Copilot AI commented Feb 23, 2026

Adds a new Chat welcome tip that surfaces browser tool integration for Agent mode users. The tip appears only when browser chat tools are not enabled and is suppressed once the setting has been customized.

Screenshot 2026-02-23 at 3 07 50 PM

Also, ensures that once a setting link has been clicked from the tip, that tip is not shown again.

  • Description

    • Introduce tip.agenticBrowser in the chat tip catalog.
    • Tip content links directly to the workbench.browser.enableChatTools setting via workbench.action.openSettings.
    • Eligibility:
      • chatModeKind === Agent
      • config.workbench.browser.enableChatTools !== true
    • Persistence/exclusion:
      • Uses existing excludeWhenSettingsChanged flow with workbench.browser.enableChatTools so it stops surfacing after user customization.
  • Test updates

    • Extend the existing parameterized excludeWhenSettingsChanged ChatTipService tests to include:
      • tip.agenticBrowser + workbench.browser.enableChatTools
    • Reuses current test coverage pattern for “shows at default” and “excluded after setting change”.
  • Code snippet

{
	id: 'tip.agenticBrowser',
	message: localize(
		'tip.agenticBrowser',
		"Tip: Enable [agentic browser integration](command:workbench.action.openSettings?%5B%22workbench.browser.enableChatTools%22%5D) to let the agent open and interact with pages in the Integrated Browser."
	),
	when: ContextKeyExpr.and(
		ChatContextKeys.chatModeKind.isEqualTo(ChatModeKind.Agent),
		ContextKeyExpr.notEquals('config.workbench.browser.enableChatTools', true),
	),
	enabledCommands: ['workbench.action.openSettings'],
	excludeWhenSettingsChanged: ['workbench.browser.enableChatTools'],
}

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • redirector.gvt1.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --enable-crash-reporter=5bd0f69d-c930-4bce-999b-9fdd9968e8ad,no_channel --user-data-dir=/tmp/vscode-tests-1771864290447 --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,6346735219836622222,16193391816832691861,262144 --enable-features=PdfUseShowSaveFilePicker --disable-features=LocalNetworkAccessChecks,ScreenAIOCREnabled,SpareRendererForSitePerProcess,TraceSiteInstanceGetProcessCreation --variations-seed-version --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: ./.build/electron/code-oss ./.build/electron/code-oss --no-sandbox test/unit/electron/index.js --grep ChatTipService (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

This section details on the original issue you should resolve

<issue_title>add a tip for agentic browser integration</issue_title>
<issue_description></issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: meganrogge <29464607+meganrogge@users.noreply.github.com>
Copilot AI changed the title [WIP] Add a tip for agentic browser integration Add agent-mode tip for enabling agentic browser integration Feb 23, 2026
@meganrogge
Copy link
Collaborator

@copilot the setting is workbench.browser.enableChatTools

Copy link
Contributor Author

Copilot AI commented Feb 23, 2026

@copilot the setting is workbench.browser.enableChatTools

Updated to use workbench.browser.enableChatTools in the tip link, eligibility check, and exclusion setting key in commit ec59878.

Screenshot: https://github.com/user-attachments/assets/c1fbe8f9-e829-4c75-9033-d0621f5dd031

@meganrogge meganrogge added this to the February 2026 milestone Feb 23, 2026
@meganrogge meganrogge marked this pull request as ready for review February 23, 2026 20:12
Copilot AI review requested due to automatic review settings February 23, 2026 20:12
@meganrogge meganrogge enabled auto-merge (squash) February 23, 2026 20:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new chat welcome tip (tip.agenticBrowser) to promote browser tool integration for Agent mode users. The tip appears when browser chat tools are disabled and is intended to be suppressed once the setting has been customized or the settings link is clicked. The PR also extends existing test coverage to validate these behaviors.

Changes:

  • Adds tip.agenticBrowser to the tip catalog with eligibility conditions based on Agent mode and browser tools setting
  • Introduces excludeWhenSettingsChanged and dismissWhenCommandsClicked fields to tip definitions
  • Implements dismiss-on-command-click functionality when users click settings links in tips
  • Extends parameterized tests to cover the new tip and its setting-based exclusion behavior

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/vs/workbench/contrib/chat/browser/chatTipService.ts Adds tip definition for tip.agenticBrowser, introduces excludeWhenSettingsChanged and dismissWhenCommandsClicked fields to ITipDefinition, implements command-click dismiss logic, and adds these fields to tip.thinkingPhrases
src/vs/workbench/contrib/chat/test/browser/chatTipService.test.ts Extends parameterized tests to include tip.agenticBrowser with setting-based exclusion tests, adds new test suite for dismissing tips when settings commands are clicked

ContextKeyExpr.notEquals('config.workbench.browser.enableChatTools', true),
),
enabledCommands: ['workbench.action.openSettings'],
excludeWhenSettingsChanged: ['workbench.browser.enableChatTools'],
Copy link

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The excludeWhenSettingsChanged field is defined in the tip definition but there is no implementation to actually check this field and exclude tips based on it. Currently, the code only has hardcoded checks for specific tip IDs (see lines 970-973 for tip.thinkingPhrases). You need to either:

  1. Add a generic implementation in the _isEligible method that checks the excludeWhenSettingsChanged field for all tips, OR
  2. Add a specific hardcoded check for tip.agenticBrowser similar to the existing check for tip.thinkingPhrases

Without this implementation, the test at line 983-990 in chatTipService.test.ts will fail because the tip will still be shown even after the setting has been changed.

Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@meganrogge meganrogge merged commit 8452d33 into main Feb 23, 2026
20 checks passed
@meganrogge meganrogge deleted the copilot/add-tip-agentic-integration branch February 23, 2026 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add a tip for agentic browser integration

3 participants