Skip to content

fix(build,amdsimd): pin to upstream commit with build failure fix #16385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
binujp wants to merge 1 commit into
base: tomls/base/main
Choose a base branch
from
Open

fix(build,amdsimd): pin to upstream commit with build failure fix #16385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions base/comps/amdsmi/amdsmi.comp.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
[components.amdsmi]

# Pin to commit that includes libdrm-2.4.130 compatibility fix needed for Azure Linux.
Copy link

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pin comment explains what is being pinned, but it’s missing the usual traceability and exit criteria used elsewhere in the repo. Please add a reference link to the Fedora dist-git commit (e.g., src.fedoraproject.org URL with branch=f43) and a TODO/condition for when this upstream-commit pin can be dropped (e.g., once the default Fedora 43 snapshot in distro config advances past this commit).

Suggested change
# Pin to commit that includes libdrm-2.4.130 compatibility fix needed for Azure Linux.
# Pin to commit that includes libdrm-2.4.130 compatibility fix needed for Azure Linux.
# Fedora dist-git reference: https://src.fedoraproject.org/rpms/amdsmi/c/033e87d8bcd9480840f42e122c2f69e2629240a2?branch=f43
# TODO: Drop this upstream-commit pin once the default Fedora 43 snapshot in the distro config advances past this commit.

Copilot uses AI. Check for mistakes.
spec = { type = "upstream", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "033e87d8bcd9480840f42e122c2f69e2629240a2" }
Comment on lines +1 to +4
Copy link

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title/description mention pinning amdsimd, but this change introduces a dedicated config for amdsmi. Please confirm which component is intended and update either the PR metadata or the component name/path so the change is unambiguous (and doesn’t accidentally pin the wrong package).

Copilot uses AI. Check for mistakes.
1 change: 0 additions & 1 deletion base/comps/components-full.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,6 @@
[components.alex]
[components.allegro]
[components.alsa-lib]
[components.amdsmi]
[components.aml]
[components.amtterm]
[components.anaconda-webui]
Expand Down
Loading