fix(build,amdsimd): pin to upstream commit with build failure fix#16385
fix(build,amdsimd): pin to upstream commit with build failure fix#16385binujp wants to merge 1 commit intotomls/base/mainfrom
Conversation
Commit 033e87d8bcd9480840f42e122c2f69e2629240a2 on f43 brings the fix for the build faiure we are hitting. Pin amdsimd to that commit. Test build with the fix worked.
There was a problem hiding this comment.
Pull request overview
Pins the amdsmi component to a specific Fedora dist-git commit to pick up an upstream build-failure fix, moving the component into a dedicated *.comp.toml file (and removing the generated entry from components-full.toml).
Changes:
- Add
base/comps/amdsmi/amdsmi.comp.tomlto pinamdsmito Fedora 43 commit033e87d8…. - Remove
[components.amdsmi]frombase/comps/components-full.tomlnow thatamdsmihas a dedicated component file.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| base/comps/components-full.toml | Removes amdsmi from the generated “no per-component modifications” list to avoid duplicate/empty component entries. |
| base/comps/amdsmi/amdsmi.comp.toml | Introduces a dedicated component definition that pins the upstream spec to a specific Fedora 43 commit. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| [components.amdsmi] | ||
|
|
||
| # Pin to commit that includes libdrm-2.4.130 compatibility fix needed for Azure Linux. | ||
| spec = { type = "upstream", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "033e87d8bcd9480840f42e122c2f69e2629240a2" } |
There was a problem hiding this comment.
PR title/description mention pinning amdsimd, but this change introduces a dedicated config for amdsmi. Please confirm which component is intended and update either the PR metadata or the component name/path so the change is unambiguous (and doesn’t accidentally pin the wrong package).
| @@ -0,0 +1,4 @@ | |||
| [components.amdsmi] | |||
|
|
|||
| # Pin to commit that includes libdrm-2.4.130 compatibility fix needed for Azure Linux. | |||
There was a problem hiding this comment.
The pin comment explains what is being pinned, but it’s missing the usual traceability and exit criteria used elsewhere in the repo. Please add a reference link to the Fedora dist-git commit (e.g., src.fedoraproject.org URL with branch=f43) and a TODO/condition for when this upstream-commit pin can be dropped (e.g., once the default Fedora 43 snapshot in distro config advances past this commit).
| # Pin to commit that includes libdrm-2.4.130 compatibility fix needed for Azure Linux. | |
| # Pin to commit that includes libdrm-2.4.130 compatibility fix needed for Azure Linux. | |
| # Fedora dist-git reference: https://src.fedoraproject.org/rpms/amdsmi/c/033e87d8bcd9480840f42e122c2f69e2629240a2?branch=f43 | |
| # TODO: Drop this upstream-commit pin once the default Fedora 43 snapshot in the distro config advances past this commit. |
Commit 033e87d8bcd9480840f42e122c2f69e2629240a2 on f43 brings the fix for the build faiure we are hitting. Pin amdsimd to that commit. Test build with the fix worked.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
Change Log
Does this affect the toolchain?
YES/NO
Associated issues
Links to CVEs
Test Methodology