Skip to content

fix(build,amdsimd): pin to upstream commit with build failure fix#16385

Open
binujp wants to merge 1 commit intotomls/base/mainfrom
bphilip/amdsimd-pin-commit
Open

fix(build,amdsimd): pin to upstream commit with build failure fix#16385
binujp wants to merge 1 commit intotomls/base/mainfrom
bphilip/amdsimd-pin-commit

Conversation

@binujp
Copy link
Copy Markdown
Contributor

@binujp binujp commented Mar 31, 2026

Commit 033e87d8bcd9480840f42e122c2f69e2629240a2 on f43 brings the fix for the build faiure we are hitting. Pin amdsimd to that commit. Test build with the fix worked.

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?

Change Log
  • Change
  • Change
  • Change
Does this affect the toolchain?

YES/NO

Associated issues
  • #xxxx
Links to CVEs
Test Methodology
  • Pipeline build id: xxxx

Commit 033e87d8bcd9480840f42e122c2f69e2629240a2 on f43 brings the fix
for the build faiure we are hitting. Pin amdsimd to that commit. Test build
with the fix worked.
Copilot AI review requested due to automatic review settings March 31, 2026 16:03
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Pins the amdsmi component to a specific Fedora dist-git commit to pick up an upstream build-failure fix, moving the component into a dedicated *.comp.toml file (and removing the generated entry from components-full.toml).

Changes:

  • Add base/comps/amdsmi/amdsmi.comp.toml to pin amdsmi to Fedora 43 commit 033e87d8….
  • Remove [components.amdsmi] from base/comps/components-full.toml now that amdsmi has a dedicated component file.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
base/comps/components-full.toml Removes amdsmi from the generated “no per-component modifications” list to avoid duplicate/empty component entries.
base/comps/amdsmi/amdsmi.comp.toml Introduces a dedicated component definition that pins the upstream spec to a specific Fedora 43 commit.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +1 to +4
[components.amdsmi]

# Pin to commit that includes libdrm-2.4.130 compatibility fix needed for Azure Linux.
spec = { type = "upstream", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "033e87d8bcd9480840f42e122c2f69e2629240a2" }
Copy link

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title/description mention pinning amdsimd, but this change introduces a dedicated config for amdsmi. Please confirm which component is intended and update either the PR metadata or the component name/path so the change is unambiguous (and doesn’t accidentally pin the wrong package).

Copilot uses AI. Check for mistakes.
@@ -0,0 +1,4 @@
[components.amdsmi]

# Pin to commit that includes libdrm-2.4.130 compatibility fix needed for Azure Linux.
Copy link

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pin comment explains what is being pinned, but it’s missing the usual traceability and exit criteria used elsewhere in the repo. Please add a reference link to the Fedora dist-git commit (e.g., src.fedoraproject.org URL with branch=f43) and a TODO/condition for when this upstream-commit pin can be dropped (e.g., once the default Fedora 43 snapshot in distro config advances past this commit).

Suggested change
# Pin to commit that includes libdrm-2.4.130 compatibility fix needed for Azure Linux.
# Pin to commit that includes libdrm-2.4.130 compatibility fix needed for Azure Linux.
# Fedora dist-git reference: https://src.fedoraproject.org/rpms/amdsmi/c/033e87d8bcd9480840f42e122c2f69e2629240a2?branch=f43
# TODO: Drop this upstream-commit pin once the default Fedora 43 snapshot in the distro config advances past this commit.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants