Skip to content

Initial support for wslc E2E testing#14299

Merged
AmelBawa-msft merged 32 commits intofeature/wsl-for-appsfrom
user/amelbawa/wslc-e2e
Mar 5, 2026
Merged

Initial support for wslc E2E testing#14299
AmelBawa-msft merged 32 commits intofeature/wsl-for-appsfrom
user/amelbawa/wslc-e2e

Conversation

@AmelBawa-msft
Copy link

@AmelBawa-msft AmelBawa-msft commented Feb 27, 2026

🧪 Summary of the Pull Request

Code summary

  • Added the foundation for E2E testing for WSLC
  • Added E2E tests

Tests added

  • WSLCE2E_Container_Create_HelpCommand
  • WSLCE2E_Container_Create_MissingImage
  • WSLCE2E_Container_Create_InvalidImage
  • WSLCE2E_Container_Create_Valid
  • WSLCE2E_Container_Create_DuplicateContainerName
  • WSLCE2E_Container_HelpCommand
  • WSLCE2E_Container_InvalidCommand_DisplaysErrorMessage
  • WSLCE2E_HelpCommand
  • WSLCE2E_InvalidCommand_DisplaysErrorMessage

PR Checklist

  • Closes: Link to issue #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated if needed and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated if needed
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@AmelBawa-msft AmelBawa-msft changed the title [Do not review] Initial support for wslc E2E testing Initial support for wslc E2E testing Mar 2, 2026
@AmelBawa-msft AmelBawa-msft marked this pull request as ready for review March 2, 2026 21:45
@AmelBawa-msft AmelBawa-msft requested a review from a team as a code owner March 2, 2026 21:45
Copilot AI review requested due to automatic review settings March 2, 2026 21:45
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an initial end-to-end (E2E) test harness for wslc.exe under the existing Windows wsltests suite, including basic help/error-path validations and initial container workflow coverage.

Changes:

  • Introduces a WSLCExecutor wrapper to launch wslc.exe, capture stdout/stderr, and verify results.
  • Adds E2E test cases for global help/invalid commands and container help/create scenarios.
  • Updates the test/windows/wslc CMake wiring to compile the new E2E sources and expose required include paths.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 10 comments.

Show a summary per file
File Description
test/windows/wslc/e2e/WSLCExecutor.h Declares execution/result structures used by E2E tests.
test/windows/wslc/e2e/WSLCExecutor.cpp Implements command execution via SubProcess and output verification helpers.
test/windows/wslc/e2e/WSLCExecutorHelpers.h Declares container-listing helper assertions for E2E tests.
test/windows/wslc/e2e/WSLCExecutorHelpers.cpp Implements helpers for parsing/list-verifying container outputs.
test/windows/wslc/e2e/WSLCCommand.h Adds convenience wrappers for building wslc subcommand invocations.
test/windows/wslc/e2e/WSLCE2EGlobalTests.cpp Adds E2E tests for wslc --help and invalid command behavior.
test/windows/wslc/e2e/WSLCE2EContainerTests.cpp Adds E2E tests for wslc container --help and invalid subcommand behavior.
test/windows/wslc/e2e/WSLCE2EContainerCreateTests.cpp Adds E2E tests for wslc container create help/error flows and a create/delete scenario.
test/windows/wslc/CMakeLists.txt Includes new E2E sources/headers in wsltests and adds test/windows/wslc include path.

@AmelBawa-msft AmelBawa-msft requested a review from OneBlue March 4, 2026 20:25
@AmelBawa-msft AmelBawa-msft enabled auto-merge (squash) March 4, 2026 20:36
@benhillis benhillis requested a review from Copilot March 4, 2026 21:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 7 comments.


You can also share your feedback on Copilot code review. Take the survey.

Copy link
Member

@benhillis benhillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few questions.

@AmelBawa-msft AmelBawa-msft requested a review from benhillis March 4, 2026 22:02
@benhillis benhillis requested a review from Copilot March 5, 2026 16:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.


You can also share your feedback on Copilot code review. Take the survey.

@AmelBawa-msft AmelBawa-msft merged commit f6fc6d6 into feature/wsl-for-apps Mar 5, 2026
8 of 10 checks passed
@AmelBawa-msft AmelBawa-msft deleted the user/amelbawa/wslc-e2e branch March 5, 2026 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants