Initial support for wslc E2E testing#14299
Merged
AmelBawa-msft merged 32 commits intofeature/wsl-for-appsfrom Mar 5, 2026
Merged
Initial support for wslc E2E testing#14299AmelBawa-msft merged 32 commits intofeature/wsl-for-appsfrom
AmelBawa-msft merged 32 commits intofeature/wsl-for-appsfrom
Conversation
OneBlue
reviewed
Feb 27, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an initial end-to-end (E2E) test harness for wslc.exe under the existing Windows wsltests suite, including basic help/error-path validations and initial container workflow coverage.
Changes:
- Introduces a
WSLCExecutorwrapper to launchwslc.exe, capture stdout/stderr, and verify results. - Adds E2E test cases for global help/invalid commands and container help/create scenarios.
- Updates the
test/windows/wslcCMake wiring to compile the new E2E sources and expose required include paths.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| test/windows/wslc/e2e/WSLCExecutor.h | Declares execution/result structures used by E2E tests. |
| test/windows/wslc/e2e/WSLCExecutor.cpp | Implements command execution via SubProcess and output verification helpers. |
| test/windows/wslc/e2e/WSLCExecutorHelpers.h | Declares container-listing helper assertions for E2E tests. |
| test/windows/wslc/e2e/WSLCExecutorHelpers.cpp | Implements helpers for parsing/list-verifying container outputs. |
| test/windows/wslc/e2e/WSLCCommand.h | Adds convenience wrappers for building wslc subcommand invocations. |
| test/windows/wslc/e2e/WSLCE2EGlobalTests.cpp | Adds E2E tests for wslc --help and invalid command behavior. |
| test/windows/wslc/e2e/WSLCE2EContainerTests.cpp | Adds E2E tests for wslc container --help and invalid subcommand behavior. |
| test/windows/wslc/e2e/WSLCE2EContainerCreateTests.cpp | Adds E2E tests for wslc container create help/error flows and a create/delete scenario. |
| test/windows/wslc/CMakeLists.txt | Includes new E2E sources/headers in wsltests and adds test/windows/wslc include path. |
… into user/amelbawa/wslc-e2e
OneBlue
reviewed
Mar 3, 2026
… into user/amelbawa/wslc-e2e
… into user/amelbawa/wslc-e2e
benhillis
reviewed
Mar 4, 2026
benhillis
reviewed
Mar 4, 2026
benhillis
reviewed
Mar 4, 2026
benhillis
reviewed
Mar 4, 2026
benhillis
reviewed
Mar 4, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 7 comments.
You can also share your feedback on Copilot code review. Take the survey.
benhillis
reviewed
Mar 5, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
You can also share your feedback on Copilot code review. Take the survey.
benhillis
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧪 Summary of the Pull Request
Code summary
Tests added
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed