Skip to content

Port image build from wsladiag to wslc#14359

Merged
johnstep merged 2 commits intofeature/wsl-for-appsfrom
user/johnstep/wslc-build
Mar 6, 2026
Merged

Port image build from wsladiag to wslc#14359
johnstep merged 2 commits intofeature/wsl-for-appsfrom
user/johnstep/wslc-build

Conversation

@johnstep
Copy link
Copy Markdown
Member

@johnstep johnstep commented Mar 5, 2026

No description provided.

@AmelBawa-msft
Copy link
Copy Markdown

LGTM! Thank you, excited to try this out! 🚀✨

@johnstep johnstep marked this pull request as ready for review March 5, 2026 19:10
@johnstep johnstep requested a review from a team as a code owner March 5, 2026 19:10
Copilot AI review requested due to automatic review settings March 5, 2026 19:10
Copy link
Copy Markdown
Member

@dkbennett dkbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a fine implementation of a new command into the model!

Comment thread src/windows/wslc/commands/ImageCommand.cpp
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@benhillis benhillis requested a review from Copilot March 5, 2026 20:09
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.


You can also share your feedback on Copilot code review. Take the survey.

Comment thread src/windows/wslc/services/ImageService.cpp Outdated
Comment thread src/windows/wslc/tasks/ImageTasks.cpp
Comment thread src/windows/wslc/services/ImageService.cpp Outdated
@AmelBawa-msft
Copy link
Copy Markdown

@johnstep If possible, I’d appreciate getting my #14299 PR merged before we add more features to the CLI. I believe there are a few other PRs waiting as well. Sorry for the inconvenience, and thanks again for your work on this!

Comment thread src/windows/wslc/services/ImageService.cpp Outdated
@johnstep johnstep force-pushed the user/johnstep/wslc-build branch from 30bdd49 to 18e0787 Compare March 6, 2026 05:55
@johnstep johnstep force-pushed the user/johnstep/wslc-build branch from 18e0787 to 9e4191f Compare March 6, 2026 06:49
@johnstep johnstep merged commit d8f6b38 into feature/wsl-for-apps Mar 6, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants