Skip to content

Enhance code review instructions with additional checks #866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
harsha-simhadri wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Enhance code review instructions with additional checks #866

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d51e2e
Enhance code review instructions with additional checks
harsha-simhadri Mar 27, 2026
a7f6a67
Update .github/instructions.md
harsha-simhadri Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/instructions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
When performing a code review, please check each file has a license header
When performing a code review, check that:
- No unit tests were eliminated without a strong reason.
- Additional dependencies introduced have a strong justification.
- Changes are not likely to increase build times.
- Each file has a license header.
```
/*
* Copyright (c) Microsoft Corporation.
Expand Down
Loading