Enhance code review instructions with additional checks#866
Open
harsha-simhadri wants to merge 2 commits intomainfrom
Open
Enhance code review instructions with additional checks#866harsha-simhadri wants to merge 2 commits intomainfrom
harsha-simhadri wants to merge 2 commits intomainfrom
Conversation
Added additional code review checks regarding unit tests, dependencies, and build times.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the repository’s code review guidance to include additional review checks beyond license headers, focusing on test coverage, dependency hygiene, and build-time impact.
Changes:
- Added checklist items to flag removed unit tests without strong justification.
- Added guidance to scrutinize newly introduced dependencies.
- Added a reminder to consider potential build time regressions, while retaining the license header check.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #866 +/- ##
==========================================
- Coverage 90.45% 89.30% -1.16%
==========================================
Files 442 442
Lines 83248 83248
==========================================
- Hits 75301 74341 -960
- Misses 7947 8907 +960
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added additional code review checks regarding unit tests, dependencies, and build times.