Skip to content

[Win] Enable function-level linking for Release #8802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Alex Sepkowski (alsepkow) wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −5
Draft

[Win] Enable function-level linking for Release #8802

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions cmake/modules/HandleLLVMOptions.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,8 +362,9 @@ if( MSVC )
append("/analyze" CMAKE_CXX_FLAGS)
endif ()

# Change release to always build debug information out-of-line, but
# also enable Reference optimization, ie dead function elimination.
# Change release to always build debug information out-of-line and enable
# function-level dead code elimination.
append("/Gy" CMAKE_C_FLAGS_RELEASE CMAKE_CXX_FLAGS_RELEASE)
if (NOT CMAKE_MSVC_DEBUG_INFORMATION_FORMAT)
append("/Zi" CMAKE_CXX_FLAGS_RELEASE)
append("/DEBUG /OPT:REF" CMAKE_SHARED_LINKER_FLAGS_RELEASE)
Expand Down Expand Up @@ -609,9 +610,6 @@ endif()
# HLSL Change Ends

# Add flags for add_dead_strip().
# FIXME: With MSVS, consider compiling with /Gy and linking with /OPT:REF?
# But MinSizeRel seems to add that automatically, so maybe disable these
# flags instead if LLVM_NO_DEAD_STRIP is set.
if(NOT CYGWIN AND NOT WIN32)
if(NOT ${CMAKE_SYSTEM_NAME} MATCHES "Darwin" AND
NOT uppercase_CMAKE_BUILD_TYPE STREQUAL "DEBUG")
Expand Down
Loading