Skip to content

Skip CodeGenFloatingPointEnvironment under x64 ARM64 emulation #8794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Alex Sepkowski (alsepkow) wants to merge 2 commits into
base: main
Choose a base branch
from
+27 −0
Open

Skip CodeGenFloatingPointEnvironment under x64 ARM64 emulation #8794

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69a21a9
Skip FP environment test under x64 ARM64 emulation
Aug 18, 2026
1319f52
Potential fix for pull request finding
alsepkow Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions tools/clang/unittests/HLSL/CompilerTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4364,7 +4364,34 @@ void VerifyDivByZeroThrows() {
VERIFY_IS_TRUE(bCaughtExpectedException);
}

static bool IsX64EmulatedOnArm64() {
#if defined(_M_X64)
using IsWow64Process2Fn = BOOL(WINAPI *)(HANDLE, USHORT *, USHORT *);
HMODULE kernel32 = GetModuleHandleW(L"kernel32.dll");
IsWow64Process2Fn isWow64Process2 = reinterpret_cast<IsWow64Process2Fn>(
GetProcAddress(kernel32, "IsWow64Process2"));
if (!isWow64Process2)
return false;

USHORT processMachine = IMAGE_FILE_MACHINE_UNKNOWN;
USHORT nativeMachine = IMAGE_FILE_MACHINE_UNKNOWN;
return isWow64Process2(GetCurrentProcess(), &processMachine,
&nativeMachine) &&
nativeMachine == IMAGE_FILE_MACHINE_ARM64;
#else
return false;
#endif
}

TEST_F(CompilerTest, CodeGenFloatingPointEnvironment) {
if (IsX64EmulatedOnArm64()) {
WEX::Logging::Log::Comment(
L"Skipping floating-point environment test under x64 emulation on "
L"ARM64.");
WEX::Logging::Log::Result(WEX::Logging::TestResults::Skipped);
return;
}

unsigned int fpOriginal;
VERIFY_IS_TRUE(_controlfp_s(&fpOriginal, 0, 0) == 0);

Expand Down
Loading