Conversation
tex3d
approved these changes
Mar 10, 2026
bob80905
approved these changes
Mar 10, 2026
damyanp
reviewed
Mar 10, 2026
Member
damyanp
left a comment
damyanp
left a comment
There was a problem hiding this comment.
LGTM, but approval should come from someone with a bit more understanding than me.
hekota
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#8202 and #8233 collided post merge to reveal a long standing bug with
-lib_6_xthat is currently breaking CI on main.This change fixes that bug by skipping reachable call diagnostics in the case that they are allowed to be transiently invalid. The comment in the PR is a bit more verbose on the details and I'll avoid reposting it here.