[SPIR-V] Add parent map when handling var init#8221
Open
Keenuts wants to merge 1 commit intomicrosoft:mainfrom
Open
[SPIR-V] Add parent map when handling var init#8221Keenuts wants to merge 1 commit intomicrosoft:mainfrom
Keenuts wants to merge 1 commit intomicrosoft:mainfrom
Conversation
ResourceHeap resource type is not know looking at the type, but at the context around it (we need to look how the variable is assigned). This means we need a parent map. When the heap is used in a function, the parentMap is set to the function scope, so everything is fine. But when a static variable is set, we are in the global scope, and the parent should be the current variable declaration. Fixes microsoft#8220
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ResourceHeap resource type is not know looking at the type, but at the context around it (we need to look how the variable is assigned).
This means we need a parent map.
When the heap is used in a function, the parentMap is set to the function scope, so everything is fine. But when a static variable is set, we are in the global scope, and the parent should be the current variable declaration.
Fixes #8220