Skip to content

[Release SM 6.9] Cherry-Pick Execution Tests: Update datasets for rhs values for shift operations #8216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alsepkow merged 1 commit into from
Mar 5, 2026
+11 −2
Merged

[Release SM 6.9] Cherry-Pick Execution Tests: Update datasets for rhs values for shift operations #8216

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions tools/clang/unittests/HLSLExec/LongVectors.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -755,8 +755,17 @@ template <typename T> uint32_t FirstBitLow(T A) {
DEFAULT_OP_2(OpType::And, (A & B));
DEFAULT_OP_2(OpType::Or, (A | B));
DEFAULT_OP_2(OpType::Xor, (A ^ B));
DEFAULT_OP_2(OpType::LeftShift, (A << B));
DEFAULT_OP_2(OpType::RightShift, (A >> B));

// HLSL/DXIL masks shift amounts to the low bits (4 bits for 16-bit, 5 bits for
// 32-bit, 6 bits for 64-bit). We must do the same in C++ to avoid undefined
// behavior when shift amount >= bit width, and to match GPU results.
template <typename T> T MaskShiftAmount(T ShiftAmount) {
constexpr T ShiftMask = static_cast<T>(sizeof(T) * 8 - 1);
return ShiftAmount & ShiftMask;
}

DEFAULT_OP_2(OpType::LeftShift, (A << MaskShiftAmount(B)));
DEFAULT_OP_2(OpType::RightShift, (A >> MaskShiftAmount(B)));
DEFAULT_OP_1(OpType::Saturate, (Saturate(A)));
DEFAULT_OP_1(OpType::ReverseBits, (ReverseBits(A)));

Expand Down