Initial HLK test for GroupSharedLimit#8160
Open
JoeCitizen wants to merge 5 commits intomicrosoft:mainfrom
Open
Initial HLK test for GroupSharedLimit#8160JoeCitizen wants to merge 5 commits intomicrosoft:mainfrom
JoeCitizen wants to merge 5 commits intomicrosoft:mainfrom
Conversation
Contributor
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
damyanp
reviewed
Feb 23, 2026
damyanp
reviewed
Feb 25, 2026
Member
damyanp
left a comment
damyanp
left a comment
There was a problem hiding this comment.
Noted a few more (but not all of the) variable names that need updating.
JoeCitizen
force-pushed
the
user/jackell/GroupSharedMemory_HLK
branch
from
8b7db59 to
1ceb7d4
Compare
alsepkow
reviewed
Mar 3, 2026
| readHlslDataIntoNewStream(L"ShaderOpArith.xml", &Stream, m_support); | ||
| st::ParseShaderOpSetFromStream(Stream, ShaderOpSet.get()); | ||
|
|
||
| // Test 1: GroupSharedLimit that is >= usage should succeed. |
Contributor
There was a problem hiding this comment.
For test 1,2,3 there seems to be a lot of duplicated code. Would it be worth factoring out common logic into a helper?
| } | ||
| } | ||
|
|
||
| void ExecutionTest::GroupSharedLimitASTest() { |
Contributor
There was a problem hiding this comment.
Shared logic with GroupSharedLimitMSTest looks ripe for some refactoring/shared helpers.
JoeCitizen
added a commit
to JoeCitizen/DirectXShaderCompiler
that referenced
this pull request
Mar 3, 2026
- Add const qualifier to MaxGSMCS/MaxGSMAS/MaxGSMMS variables - Add _HLK_CONF / FailIfRequirementsNotMet device creation logic - Extract RunGSMLimitShaderAndVerify helper to reduce duplication - Remove unused NUM_THREADS variables from CS test scopes Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Add const qualifier to MaxGSMCS/MaxGSMAS/MaxGSMMS variables - Add _HLK_CONF / FailIfRequirementsNotMet device creation logic - Extract RunGSMLimitShaderAndVerify helper to reduce duplication - Remove unused NUM_THREADS variables from CS test scopes Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
JoeCitizen
force-pushed
the
user/jackell/GroupSharedMemory_HLK
branch
from
6ab7b1d to
17229ae
Compare
alsepkow
reviewed
Mar 3, 2026
alsepkow
reviewed
Mar 4, 2026
alsepkow
reviewed
Mar 4, 2026
alsepkow
reviewed
Mar 4, 2026
alsepkow
reviewed
Mar 4, 2026
- Extract CreateGSMLimitTestDevice helper for device creation + HLK skip logic - Use VERIFY_SUCCEEDED in getMaxGroupSharedMemory* instead of silent fallback - Fix Test 2 comment wording per reviewer suggestion - Use named constant GSM_BYTES_TEST2 instead of magic number 36864 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.