[SM6.10] Add HLSL MatrixRef type and lower CreateMatrix intrinsic#8040
Closed
[SM6.10] Add HLSL MatrixRef type and lower CreateMatrix intrinsic#8040
Conversation
hekota
approved these changes
Jan 7, 2026
Comment on lines
+5
to
+9
| // AST: |-CXXRecordDecl {{[^ ]+}} <<invalid sloc>> <invalid sloc> implicit referenced class __builtin_LinAlg_MatrixRef definition | ||
| // AST-NEXT: | |-FinalAttr {{[^ ]+}} <<invalid sloc>> Implicit final | ||
| // AST-NEXT: | |-AvailabilityAttr {{[^ ]+}} <<invalid sloc>> Implicit 6.10 0 0 "" | ||
| // AST-NEXT: | |-HLSLMatrixRefAttr {{[^ ]+}} <<invalid sloc>> Implicit | ||
| // AST-NEXT: | |-FieldDecl {{[^ ]+}} <<invalid sloc>> <invalid sloc> implicit h 'int' |
Member
There was a problem hiding this comment.
Suggested change
| // AST: |-CXXRecordDecl {{[^ ]+}} <<invalid sloc>> <invalid sloc> implicit referenced class __builtin_LinAlg_MatrixRef definition | |
| // AST-NEXT: | |-FinalAttr {{[^ ]+}} <<invalid sloc>> Implicit final | |
| // AST-NEXT: | |-AvailabilityAttr {{[^ ]+}} <<invalid sloc>> Implicit 6.10 0 0 "" | |
| // AST-NEXT: | |-HLSLMatrixRefAttr {{[^ ]+}} <<invalid sloc>> Implicit | |
| // AST-NEXT: | |-FieldDecl {{[^ ]+}} <<invalid sloc>> <invalid sloc> implicit h 'int' | |
| // AST: CXXRecordDecl {{.*}} implicit referenced class __builtin_LinAlg_MatrixRef definition | |
| // AST-NEXT: FinalAttr {{.*}} Implicit final | |
| // AST-NEXT: AvailabilityAttr {{.*}} Implicit 6.10 0 0 "" | |
| // AST-NEXT: HLSLMatrixRefAttr {{.*}} Implicit | |
| // AST-NEXT: FieldDecl {{.*}} implicit h 'int' |
Just a nit - consider simplifying the checks for better readability.
spall
reviewed
Jan 7, 2026
Collaborator
spall
left a comment
There was a problem hiding this comment.
looks okay to me but I'm not confident enough in this area to approve
Collaborator
Author
|
This PR is defunct under the latest spec changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
__builtin_LinAlg_MatrixReftype to HLSL__builtin_LinAlg_CreateMatrixwhich currently returns an unannotated MatrixRef.__builtin_LinAlg_MatrixRefNotes:
__builtin_LinAlg_MatrixRef