fix: validate catalog kind overrides#97
Merged
kunallanjewar merged 2 commits intoMay 27, 2026
Merged
Conversation
github-actions
Bot
added
area: lore
kunallanjewar
approved these changes
May 27, 2026
Contributor
kunallanjewar
left a comment
kunallanjewar
left a comment
There was a problem hiding this comment.
Reuses the existing ErrInvalidKind sentinel + isValidKind helper from inscribe.go, keeps the validation layer consistent with Inscribe and Update. errors.Is + zero-row assertion in the test verify the up-front-rejection invariant from #87. CHANGELOG entry and the docs/generated/cli.md drift fix for the #61 flags are correct hygiene. Thanks for the careful patch.
This was referenced May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #87
Validates explicit
lore catalog --kindoverrides before walking/importing markdown files. Invalid values now return the existing invalid-kind error with the valid taxonomy listed, and no entries are inserted.I also refreshed generated CLI docs because
make checksurfaced existing generated-doc drift forguild mcp install --update/--force.Tests
GOMODCACHE=$PWD/.gomodcache GOCACHE=$PWD/.gocache go test ./internal/lore -run CatalogPATH=$PWD/.bin:$PATH GOMODCACHE=$PWD/../guild-gomodcache GOCACHE=$PWD/../guild-gocache make check