Skip to content

[codex] Fix CLI help and quest diagnostics#95

Closed
MukundaKatta wants to merge 3 commits into
mathomhaus:mainfrom
MukundaKatta:codex/validate-lore-catalog-kind
Closed

[codex] Fix CLI help and quest diagnostics#95
MukundaKatta wants to merge 3 commits into
mathomhaus:mainfrom
MukundaKatta:codex/validate-lore-catalog-kind

Conversation

@MukundaKatta
Copy link
Copy Markdown

Summary

  • regroup root help into Core and Inspection command groups
  • align root help vocabulary around lore and quest verbs
  • remove stale root help wording such as static binary and alias-forward references
  • include quest diagnostics and storage robustness fixes already verified on this branch

Fixes #60
Refs #26
Refs #29

Validation

  • go test ./internal/cli ./internal/quest ./internal/mcp
  • git diff --check

@github-actions github-actions Bot added area: quest Quest board / task coordination area: lore Lore knowledge archive area: mcp MCP server / protocol area: cli CLI surface / cobra verbs area: install guild init / mcp install / release labels May 15, 2026
@MukundaKatta MukundaKatta force-pushed the codex/validate-lore-catalog-kind branch from f2c4cc8 to 31ef34c Compare May 15, 2026 02:13
@MukundaKatta MukundaKatta marked this pull request as ready for review May 15, 2026 02:13
@kunallanjewar
Copy link
Copy Markdown
Contributor

Thanks for the broad pass here. There's real work in this PR (#60's cobra command groups, the codex mcp list wire-up for the registration pre-check, the storage sqlite_error helper, the quest scroll improvements) and I'd like to land the pieces individually. Closing this one because the 47-file bundle has become unmergeable in its current shape:

  • The lore catalog --kind validation is now redundant: fix: validate catalog kind overrides #97 landed today and reuses the existing ErrInvalidKind / isValidKind machinery in inscribe.go.
  • The 0o755 → 0o700 changes in cli/lore_read.go and cli/quest.go are superseded by fix(install): create ~/.guild with 0700 perms #80 (also landed today), which centralises this through a new internal/guildpath package with EnsureDir + TightenDBPerms so all six call sites stay consistent and the WAL/SHM/journal sidecars get tightened too.
  • The branch is now behind main with real conflicts on those files, and the bundling makes per-concern review hard.

If you're up for it, the highest-leverage splits I'd happily take as separate PRs against current main:

  1. cli: regroup root --help and unify domain verbs #60 root-help command groups — the Core/Inspection grouping in internal/cli/root.go plus the GroupID additions across the verb files and the root_test.go assertions. Standalone, ~80 lines.
  2. codex ListArgv wire-up — internal/install/clients.go (the one-line set) plus the well-formed test guard. Standalone, ~5 lines.
  3. Quest scroll "why blocked" surface ([feature] surface "why is this quest blocked" without requiring SQL access #29) — internal/quest/scroll.go, scroll_cmd.go, scroll_test.go. Standalone medium PR worth landing on its own merits.
  4. internal/storage/sqlite_error helper + db.go integration — useful primitive, deserves its own focused review.
  5. embedder_health_cmd OpenQuestDB wiring — depends on the Deps change in command.go; ship together.

Each of those would land in a fraction of the time a 47-file PR does, and you'd avoid the merge-cliff problem when other contributors are working the same surfaces. If you'd rather rebase and split inside this PR, that works too — just reopen.

Appreciate the contribution and hope to see the splits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: cli CLI surface / cobra verbs area: install guild init / mcp install / release area: lore Lore knowledge archive area: mcp MCP server / protocol area: quest Quest board / task coordination

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cli: regroup root --help and unify domain verbs

2 participants