fix(ci): download artifact before pnpm setup in publish job#147
Merged
Conversation
The publish job has no checkout step, so package.json (with the packageManager field) only exists after the artifact download. Running pnpm/action-setup first left it with no pnpm version to read.
There was a problem hiding this comment.
Pull request overview
This PR fixes the publish job in the release workflow by ensuring package.json is present before pnpm/action-setup runs, allowing pnpm to read the packageManager field and select the correct pnpm version.
Changes:
- Move the “Download package artifact” step earlier in the
publishjob. - Ensure pnpm setup happens after the artifact (including
package.json) is available.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
publishjob has nocheckoutstep, sopackage.json(with thepackageManagerfield) only exists after the artifact download. Runningpnpm/action-setupfirst left it with no pnpm version to read, causing "No pnpm version is specified".Fix: reorder so the artifact download runs before pnpm setup.
Fixes the failure in this run.