fix(ci): download artifact before pnpm setup in release publish job#146
Closed
Light2Dark wants to merge 1 commit into
Closed
fix(ci): download artifact before pnpm setup in release publish job#146Light2Dark wants to merge 1 commit into
Light2Dark wants to merge 1 commit into
Conversation
The publish job has no checkout step and resolves the pnpm version from package.json's packageManager field. Setup pnpm ran before the artifact was downloaded, so no package.json existed yet, causing "No pnpm version is specified". Reorder so the artifact (which contains package.json) is downloaded first. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Fixes the publish job in the Release GitHub Actions workflow by ensuring the build artifact (containing package.json) is present before pnpm/action-setup runs, preventing failures when pnpm resolves its version from packageManager in package.json.
Changes:
- Move
actions/download-artifactearlier in thepublishjob sopackage.jsonexists beforepnpm/action-setupruns.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Closed by #147 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
publishjob in the release workflow has no checkout step and only consumes the build artifact, butSetup pnpmran before the artifact was downloaded. Sincepnpm/action-setup@v6resolves its version frompackage.json'spackageManagerfield and nopackage.jsonexisted in the workspace yet, the job failed with "No pnpm version is specified" — which broke the v0.2.6 release.This reorders the publish job so the artifact (which includes
package.json) is downloaded beforeSetup pnpm, keeping the pnpm version in a single source of truth. Note: v0.2.6 never published, so a tag will need to be re-pushed after this merges.