fix(tui): prevent crash when /rewind picker triggers session remount#466
Open
Kailigithub wants to merge 1 commit into
Open
fix(tui): prevent crash when /rewind picker triggers session remount#466Kailigithub wants to merge 1 commit into
Kailigithub wants to merge 1 commit into
Conversation
When /rewind is invoked via the picker, the callback (_do_rewind) truncates session messages and calls _remount_current_session(), which removes all widgets from the container. Back in _collapse_choice(), the anchor widget reference still exists but is now detached, causing a crash on mount(after=anchor). Add a guard that checks is_mounted on the anchor widget after the on_select callback. If the callback already rebuilt the UI, return early to avoid operating on detached widgets. Closes lsdefine#421
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
/rewindis invoked via the picker in the TUI, the callback(
_do_rewind) truncates session messages and calls_remount_current_session(), which removes all widgets from the#messagescontainer. Back in_collapse_choice(), the anchor widgetreference (
msg._hint_widget/msg._body_widget) still exists but isnow detached, causing a crash when trying to
container.mount(after=anchor).Fix: Add a guard after the
on_selectcallback that checksanchor.is_mounted. If the callback already rebuilt the UI (anchor isdetached), return early to avoid operating on detached widgets.
For normal callbacks that don't remount, the anchor widgets remain
mounted and the guard is a no-op — behavior is unchanged.
Closes #421