Skip to content

fix(tui): prevent crash when /rewind picker triggers session remount #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kailigithub wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −1
Open

fix(tui): prevent crash when /rewind picker triggers session remount #466

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion frontends/tuiapp_v2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2750,6 +2750,11 @@ def _collapse_choice(self, msg: ChatMessage, idx: int) -> None:
result_text = msg.on_select(value)
except Exception as e:
result_text = f"❌ 失败: {type(e).__name__}: {e}"
# If on_select rebuilt the message container (e.g. /rewind),
# the old anchor widgets are now detached — skip collapse.
anchor = msg._hint_widget or msg._body_widget
if anchor is not None and hasattr(anchor, 'is_mounted') and not anchor.is_mounted:
return
display = (result_text or label).strip() or label
msg.selected_label = display
msg.content = display
Expand All @@ -2759,7 +2764,6 @@ def _collapse_choice(self, msg: ChatMessage, idx: int) -> None:
body.append("✓ ", style=C_GREEN)
body.append(display, style=C_FG)
new_widget = SelectableStatic(body, classes="msg")
anchor = msg._hint_widget or msg._body_widget
if anchor is not None:
container.mount(new_widget, after=anchor)
else:
Expand Down