[sw,bootrom] Add LED animation on exception#630
Conversation
marnovandermaas
left a comment
marnovandermaas
left a comment
There was a problem hiding this comment.
I haven't yet tested this but the code looks good so I'll approve to unblock. Also I think I've found a small bug in nearby code, maybe we can fix that in this PR as well?
Signed-off-by: Douglas Reis <doreis@lowrisc.org>
Signed-off-by: Douglas Reis <doreis@lowrisc.org>
| #define MAJOR "00" | ||
| #define MINOR "01" | ||
| #define MINOR "02" | ||
| #define PATCH "00" |
There was a problem hiding this comment.
I think this could be updated in a different PR, I've also noticed that it doesn't follow the versioning used in https://github.com/lowRISC/mocha/#release-timeline, maybe best to just have it be one string like "v0.2"? I doubt we will be updating the versions frequently enough to need so much granularity.
There was a problem hiding this comment.
I think it's nice to have this done in this PR so we can make the release.
This will show that the bitstream is live when a program is not loaded to DRAM. Signed-off-by: Douglas Reis <doreis@lowrisc.org>
marnovandermaas
left a comment
marnovandermaas
left a comment
There was a problem hiding this comment.
This looks good to me and works on my board.
3 participants
This will show that the bitstream is live when a program is not loaded to DRAM.
Supersedes #625
Closes: #624