Update lowrisc_ip to lowRISC/opentitan@7daa08fc83#442
Open
KinzaQamar wants to merge 1 commit intolowRISC:mainfrom
Open
Update lowrisc_ip to lowRISC/opentitan@7daa08fc83#442KinzaQamar wants to merge 1 commit intolowRISC:mainfrom
KinzaQamar wants to merge 1 commit intolowRISC:mainfrom
Conversation
Update code from upstream repository https://github.com/lowRISC/opentitan to revision 7daa08fc8382a14f4a525e6862b4bd99e3b01376 * [alert_handler,dv] Improve error messages on crashdump mismatch (Rupert Swarbrick) * [GPIO, dep] Move the dependency on gpio_straps_if to the correct place (Kinza Qamar) * [alert,dv] Make the base driver explicit that it's just for alerts (Rupert Swarbrick) * [earlgrey,dv] Remove bogus dmi device from TopEarlgrey (Rupert Swarbrick) * [tlul,dv] Expand the logic in bus2reg a little (Rupert Swarbrick) * [tl,dv] Add information about RACL bit layout to tl_reg_adapter (Rupert Swarbrick) * [alert,dv] Rename esc_sender_driver::do_reset to reset_esc (Rupert Swarbrick) * [alert,dv] Avoid escalation drivers extending alert_esc_base_driver (Rupert Swarbrick) * [fpv,tool] Revert "[fpv/tool] parse results calculation" (Rupert Swarbrick) * [dv,jtag] Downgrade jtag monitor messages to UVM_HIGH (Rupert Swarbrick) * [spi_agent,dv] Make error more helpful on duplicate opcode (Rupert Swarbrick) * [chip, dv] Unrecognized hierarchical path argument in task (Kinza Qamar) * [verilator] Support loading binary files (Chris Frantz) * [doc] Update IP READMEs with new regression links (Pascal Etterli) * [alert,dv] Make the alert/esc monitor control cfg.in_reset (Rupert Swarbrick) * [dv] Get rid of dv_base_reg_field::set_original_access (Rupert Swarbrick) * [pwrmgr,dv] Properly connect up pwrmgr_sec_cm_checker_assert (Rupert Swarbrick) * [jtag_dmi,dv] Make a size check more explicit in sba_access_monitor (Rupert Swarbrick) * [tl,dv] Use out-of-block definitions in tl_reg_adapter.sv (Rupert Swarbrick) * [tlul/rtl] Split data and integrity of `u_sync_fifo` FIFO (Pascal Nasahl) * [tlul/rtl] Duplicate the `u_sync_fifo_a_size` FIFO (Pascal Nasahl) * [tlul/rtl] Introduce dedicated readback_err signal (Pascal Nasahl) * [dv] Add documentation comments to cip_base_env (Rupert Swarbrick) * [dv] Switch to out-of-block definitions in cip_base_env (Rupert Swarbrick) * [dv,alert_handler] Improve an error in alert_handler_scoreboard (Rupert Swarbrick) * [topgen, doc] Document random netlist constant generation for tapeout (Pirmin Vogel) * [dv] Add some documentation to dv_base_agent (Rupert Swarbrick) * [dv] Add a very minor documentation note to dv_base_agent_cov (Rupert Swarbrick) * [dv] Add documentation comments to dv_base_agent_cfg (Rupert Swarbrick) * [dv,csrng] Get rid of the agent's under_reset flag (Rupert Swarbrick) * [util, regtool] Introduce vendor specific attributes (Douglas Reis) * [dv] Remove unnecessary empty driver run_phase implementations (Rupert Swarbrick) * [dv,uart] Get rid of uart_agent_cfg::under_reset (Rupert Swarbrick) * [dv] Document tasks in dv_base_driver (Rupert Swarbrick) * [alert,dv] Make overrides more local (Rupert Swarbrick) * [alert,dv] Remove alert_esc_base_monitor::wait_for_reset_done (Rupert Swarbrick) * [dv] Allow dv_base_env to work if clk_rst_ifs are already in cfg (Rupert Swarbrick) * [dv,tl_agent] Allow interface to be supplied in cfg (Rupert Swarbrick) * [dv,jtag_agent] Allow interfaces to be supplied in cfg (Rupert Swarbrick) * [dv] Remove the IfName parameter from clk_rst_if (Rupert Swarbrick) * [prim_subreg_shadow] Prevent X-propagation for W1S/W0C shadow registers (Pirmin Vogel) * [dv] Remove two unused flags from dv_base_mem (Rupert Swarbrick) * [lc_ctrl,assert] Express LcInitDoneSticky_A more comfortably (Rupert Swarbrick) * [prim_subreg_shadow] Align remaining prim_subreg[_arb] instantiations (Pirmin Vogel) * [prim_subreg_shadow] Reduce area of shadow register implementation (Pirmin Vogel) Signed-off-by: Kinza Qamar <kqzaman@lowrisc.org>
Collaborator
marnovandermaas
left a comment
marnovandermaas
left a comment
There was a problem hiding this comment.
I think it would be better for the vendor commit to be just the one generated by the vendor tool and the changes to the generated RTL to be in a separate commit.
Contributor
Do you mean one commit for the hash update in the lock file and then everything else in a separate commit or do you really meant RTL being separated? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reason for this PR depends on #382. There is a block level
.corefile missing a dependency on an interface that is added in thetop_chip_sim.corebut probably the best way is to fix this in thevendorrepo and pull the change in. Unfortunately, the commits in b/w are also pulled in.Command used for vendoring:
util/vendor.py --update hw/vendor/lowrisc_ip.vendor.hjson --commit--- creates a long commit at the endBut I need to run
util/artefacts.pyas well because the above command didn't modify the templated code