-
Notifications
You must be signed in to change notification settings - Fork 118
update to protobuf gencode 5, depends on protobuf >= 5 #723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Protobuf dependency not bumped to >=5 in livekit-api/pyproject.toml, inconsistent with other packages
The PR bumps
protobufandtypes-protobuffrom>=4to>=5in bothlivekit-protocol/pyproject.toml:28-29andlivekit-rtc/pyproject.toml:35-36, but leaveslivekit-api/pyproject.tomlatprotobuf>=4andtypes-protobuf>=4(lines 33-34). This is an incomplete transformation. Thelivekit-apipackage directly importslivekit.protocolstubs (e.g.livekit-api/livekit/api/__init__.py:28-37), which now callValidateProtobufRuntimeVersion(…, 5, …)and requireprotobuf>=5. While pip would transitively enforce>=5through thelivekit-protocoldependency, the directprotobuf>=4spec is misleading and could allow an inconsistent resolution if an olderlivekit-protocolversion is pinned.(Refers to lines 33-34)
Was this helpful? React with 👍 or 👎 to provide feedback.