update to protobuf gencode 5, depends on protobuf >= 5#723
Conversation
There was a problem hiding this comment.
🟡 Protobuf dependency not bumped to >=5 in livekit-api/pyproject.toml, inconsistent with other packages
The PR bumps protobuf and types-protobuf from >=4 to >=5 in both livekit-protocol/pyproject.toml:28-29 and livekit-rtc/pyproject.toml:35-36, but leaves livekit-api/pyproject.toml at protobuf>=4 and types-protobuf>=4 (lines 33-34). This is an incomplete transformation. The livekit-api package directly imports livekit.protocol stubs (e.g. livekit-api/livekit/api/__init__.py:28-37), which now call ValidateProtobufRuntimeVersion(…, 5, …) and require protobuf>=5. While pip would transitively enforce >=5 through the livekit-protocol dependency, the direct protobuf>=4 spec is misleading and could allow an inconsistent resolution if an older livekit-protocol version is pinned.
(Refers to lines 33-34)
Was this helpful? React with 👍 or 👎 to provide feedback.
No description provided.