Skip to content

update to protobuf gencode 5, depends on protobuf >= 5#723

Open
davidzhao wants to merge 4 commits into
mainfrom
dz/dev-protocol
Open

update to protobuf gencode 5, depends on protobuf >= 5#723
davidzhao wants to merge 4 commits into
mainfrom
dz/dev-protocol

Conversation

@davidzhao

Copy link
Copy Markdown
Member

No description provided.

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

Open in Devin Review

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Protobuf dependency not bumped to >=5 in livekit-api/pyproject.toml, inconsistent with other packages

The PR bumps protobuf and types-protobuf from >=4 to >=5 in both livekit-protocol/pyproject.toml:28-29 and livekit-rtc/pyproject.toml:35-36, but leaves livekit-api/pyproject.toml at protobuf>=4 and types-protobuf>=4 (lines 33-34). This is an incomplete transformation. The livekit-api package directly imports livekit.protocol stubs (e.g. livekit-api/livekit/api/__init__.py:28-37), which now call ValidateProtobufRuntimeVersion(…, 5, …) and require protobuf>=5. While pip would transitively enforce >=5 through the livekit-protocol dependency, the direct protobuf>=4 spec is misleading and could allow an inconsistent resolution if an older livekit-protocol version is pinned.

(Refers to lines 33-34)

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant