Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lightspeed-stack.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ llama_stack:
# The instance would have already been started with a llama-stack-run.yaml file
use_as_library_client: false
# Alternative for "as library use"
# use_as_library_client: true
# library_client_config_path: <path-to-llama-stack-run.yaml-file>
url: http://llama-stack:8321
api_key: xyzzy
use_as_library_client: true
library_client_config_path: run.yaml
# url: http://llama-stack:8321
# api_key: xyzzy
user_data_collection:
feedback_enabled: true
feedback_storage: "/tmp/data/feedback"
Expand Down
1 change: 0 additions & 1 deletion run.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ apis:
benchmarks: []
datasets: []
image_name: starter
external_providers_dir: ${env.EXTERNAL_PROVIDERS_DIR}

providers:
inference:
Expand Down
6 changes: 1 addition & 5 deletions src/app/endpoints/responses.py
Original file line number Diff line number Diff line change
Expand Up @@ -165,13 +165,9 @@ async def responses_endpoint_handler(
if responses_request.reasoning is not None:
logger.warning("reasoning is not yet supported in LCORE and will be ignored")
responses_request.reasoning = None
if responses_request.max_output_tokens is not None:
logger.warning(
"max_output_tokens is not yet supported in LCORE and will be ignored"
)
responses_request.max_output_tokens = None

responses_request = responses_request.model_copy(deep=True)

check_configuration_loaded(configuration)
responses_request.instructions = get_system_prompt(
responses_request.instructions, field_name="instructions"
Expand Down
4 changes: 4 additions & 0 deletions src/utils/types.py
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,10 @@ class ResponsesApiParams(BaseModel):
default=None,
description="Reasoning configuration for the response",
)
safety_identifier: Optional[str] = Field(
default=None,
description="Stable identifier for safety monitoring and abuse detection",
)
store: bool = Field(description="Whether to store the response")
stream: bool = Field(description="Whether to stream the response")
temperature: Optional[float] = Field(
Expand Down
6 changes: 0 additions & 6 deletions tests/e2e/features/responses.feature
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@ Feature: Responses endpoint API tests
Then The status code of the response is 200
And The body of the response contains hello

# https://redhat.atlassian.net/browse/LCORE-1583
@skip
Scenario: Responses accepts passthrough parameters with valid types
Given The system is in default state
And I set the Authorization header to Bearer eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiIxMjM0NTY3ODkwIiwibmFtZSI6Ikpva
Expand All @@ -28,8 +26,6 @@ Feature: Responses endpoint API tests
"model": "{PROVIDER}/{MODEL}",
"stream": false,
"instructions": "You are a helpful assistant.",
"prompt": {"id": "e2e_responses_passthrough_prompt"},
"reasoning": {"effort": "low"},
"safety_identifier": "e2e-responses-passthrough",
"text": {"format": {"type": "text"}},
"tool_choice": "auto",
Expand All @@ -51,8 +47,6 @@ Feature: Responses endpoint API tests
"status": "completed",
"model": "{PROVIDER}/{MODEL}",
"instructions": "You are a helpful assistant.",
"prompt": {"id": "e2e_responses_passthrough_prompt"},
"reasoning": {"effort": "low"},
"safety_identifier": "e2e-responses-passthrough",
"text": {"format": {"type": "text"}},
"tool_choice": "auto",
Expand Down
22 changes: 0 additions & 22 deletions tests/e2e/test_list.txt
Original file line number Diff line number Diff line change
@@ -1,23 +1 @@
features/faiss.feature
features/inline_rag.feature
features/smoketests.feature
features/authorized_noop.feature
features/authorized_noop_token.feature
features/authorized_rh_identity.feature
features/rbac.feature
features/conversations.feature
features/conversation_cache_v2.feature
features/feedback.feature
features/health.feature
features/info.feature
features/responses.feature
features/responses_streaming.feature
features/query.feature
features/rlsapi_v1.feature
features/rlsapi_v1_errors.feature
features/streaming_query.feature
features/rest_api.feature
features/models.feature
features/proxy.feature
features/tls.feature
features/mcp.feature
Loading