Skip to content

LCORE-1583: Allowed reasoning and max_output_tokens attributes#1483

Draft
asimurka wants to merge 1 commit intolightspeed-core:mainfrom
asimurka:allow_responses_attributes
Draft

LCORE-1583: Allowed reasoning and max_output_tokens attributes#1483
asimurka wants to merge 1 commit intolightspeed-core:mainfrom
asimurka:allow_responses_attributes

Conversation

@asimurka
Copy link
Copy Markdown
Contributor

@asimurka asimurka commented Apr 10, 2026

Description

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement
  • Benchmarks improvement

Tools used to create PR

Identify any AI code assistants used in this PR (for transparency and review context)

  • Assisted-by: N/A

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Summary by CodeRabbit

  • Bug Fixes

    • Fixed handling of request parameters that were previously being cleared from responses, allowing these parameters to be properly processed.
  • Tests

    • Updated test cases for responses feature and removed outdated test scenarios.

@asimurka asimurka marked this pull request as draft April 10, 2026 13:07
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 10, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 93e5d572-5128-4943-a331-5ecbd60ce75c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

These changes remove deprecated field-clearing logic from the responses endpoint handler and streamline test configurations by eliminating a skipped test scenario, removing unsupported tool_choice parameters from response assertions, and pruning e2e feature entries from the test list.

Changes

Cohort / File(s) Summary
Endpoint Handler
src/app/endpoints/responses.py
Removed logic that forcibly cleared unsupported LCORE fields (reasoning and max_output_tokens) with warning logs. Function now only performs deep copy before configuration checks and prompt transformations.
Test Updates
tests/e2e/features/responses.feature, tests/e2e/test_list.txt
Removed skipped test scenario for LCORE-1583. Updated "Responses accepts passthrough parameters" scenario by removing tool_choice: "auto" field from both request and expected response assertions. Removed 22 e2e feature entries from test list, retaining only responses.feature.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title describes allowing reasoning and max_output_tokens attributes, but the changeset actually removes the logic that cleared/blocked these attributes, making the title potentially misleading about the implementation approach. Consider revising the title to more accurately reflect the change, such as 'Remove unsupported LCORE field validation from responses handler' or 'Stop clearing reasoning and max_output_tokens in responses endpoint' to better represent the actual code modification.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@asimurka asimurka force-pushed the allow_responses_attributes branch from 7cd8248 to e89b907 Compare April 10, 2026 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant