proof: add byte expression helper bridges#2189
Open
Th0rgal wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_6626c325-7f4d-4e47-a8cc-7aba28217c52) |
Contributor
There was a problem hiding this comment.
OpenCodeReview first-pass review
Status: success · Mode: medium-lean · 0 finding(s) · 2 files · 443369 tokens · 39 tool calls
No comments generated. Looks good to me.
OCR pilot metrics
- Routing: medium-lean (router-v8)
- Changed files: 2 supported / 2 total; Lean 2, trust docs 0, workflow/scripts 0, contracts 0, docs 0
- Changed lines: 234 supported; thresholds large Lean >=3 files or >800 lines
- OCR: status success; comments 0; files 2; tokens 443369; tool calls 39; warnings 0; duration 335s
- Largest changed files: Compiler/Proofs/HelperStepProofs.lean (+224/-0), PrintAxioms.lean (+9/-1)
Pilot mode: advisory only. Codex Review remains the merge gate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expr.bytesource/Yul value for normalized byte extractionExpr.byteExpr.bytePrintAxioms.leanValidation
lean-slot lake build Compiler.Proofs.HelperStepProofspython3 scripts/check_proof_length.pypython3 scripts/generate_print_axioms.pypython3 scripts/generate_print_axioms.py --checkgit diff --checkrg -n "\\b(sorry|admit|axiom)\\b|set_option\\s+autoImplicit\\s+true" Compiler/Proofs/HelperStepProofs.lean(no matches)Notes
codex/2080-expr-helper-shr-threaded.PrintAxioms.leanreports5782 theorems/lemmas (4022 public, 1760 private, 0 sorry'd).Note
Low Risk
Formal proof-only changes following an established binary-op helper pattern; no runtime, auth, or production compiler behavior changes.
Overview
Extends the compiler correctness proof chain for
Expr.byteusing the same pattern asshr/shl: a sharedexprByteValue(viaVerity.Core.Uint256.byte), plus lemmas thatcompileExprWithInternalsemitsYulExpr.call "byte", sourceevalExprWithHelpersand YulevalBuiltinCallWithEvmYulLeanContextagree on that value, and the result stays belowevmModulus.Adds left- and right-threaded
ExprInternalHelperCompositionalContextResult/PostStateResultbridges by plugging those facts into the existing binary builtin threaded helpers ("byte", no shadowing internalbyte).PrintAxioms.leanis regenerated (+8 public theorems, 5782 total).Reviewed by Cursor Bugbot for commit 7d54a05. Bugbot is set up for automated code reviews on this repo. Configure here.