proof: add signextend expression helper bridges#2190
Open
Th0rgal wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_8e3271c6-256f-4da4-ada8-e3af7e2d8f4b) |
Contributor
There was a problem hiding this comment.
OpenCodeReview first-pass review
Status: success · Mode: medium-lean · 0 finding(s) · 2 files · 264924 tokens · 22 tool calls
No comments generated. Looks good to me.
OCR pilot metrics
- Routing: medium-lean (router-v8)
- Changed files: 2 supported / 2 total; Lean 2, trust docs 0, workflow/scripts 0, contracts 0, docs 0
- Changed lines: 241 supported; thresholds large Lean >=3 files or >800 lines
- OCR: status success; comments 0; files 2; tokens 264924; tool calls 22; warnings 0; duration 213s
- Largest changed files: Compiler/Proofs/HelperStepProofs.lean (+231/-0), PrintAxioms.lean (+9/-1)
Pilot mode: advisory only. Codex Review remains the merge gate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expr.signextendsource/Yul value for normalized sign-extensionExpr.signextendExpr.signextendPrintAxioms.leanValidation
lean-slot lake build Compiler.Proofs.HelperStepProofspython3 scripts/check_proof_length.pypython3 scripts/generate_print_axioms.pypython3 scripts/generate_print_axioms.py --checkgit diff --checkrg -n "\\b(sorry|admit|axiom)\\b|set_option\\s+autoImplicit\\s+true" Compiler/Proofs/HelperStepProofs.lean(no matches)Notes
codex/2080-expr-helper-byte-threaded.PrintAxioms.leanreports5790 theorems/lemmas (4030 public, 1760 private, 0 sorry'd).Note
Low Risk
Proof-only additions with no changes to compilation or runtime semantics; mirrors an established byte-helper pattern.
Overview
Adds Lean proof infrastructure for
Expr.signextendinHelperStepProofs.lean, following the same pattern as the existingbytehelpers.Introduces
exprSignextendValue(normalizedUint256.signextendresult) plus lemmas tying compilation toYulExpr.call "signextend", source evaluation, and EVM builtin semantics. Four threaded theorems lift child compositional context and post-state results to the fullsignextendexpression (left- and right-eval order).PrintAxioms.leanis regenerated to register the eight new public theorems (theorem count 5782 → 5790).Reviewed by Cursor Bugbot for commit 4de2bd9. Bugbot is set up for automated code reviews on this repo. Configure here.