Fix certs e2e test for k8s 1.35

[sohankunkerkar]

In k8s 1.35, Deployment.Status.TerminatingReplicas returns *int32(0) instead of nil when there are no terminating replicas. Use ptr.Deref to handle both cases.

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes https://gcsweb.k8s.io/gcs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_kueue/8500/pull-kueue-test-e2e-main-1-35/2009664144264925184/

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

[netlify]

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name	Link
🔨 Latest commit	1eaeb6d
🔍 Latest deploy log	https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/696137956e39740008469e26
😎 Deploy Preview	https://deploy-preview-8505--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[tenzen-y]

Thank you!
/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Details

Git tree hash: e4e29a4b2162388a650df50bab2b828ef1975cf4

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sohankunkerkar, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• test/OWNERS [tenzen-y]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mimowo]

LGTM, thank you 👍

[Copilot]

Pull request overview

This PR fixes an e2e test failure in Kubernetes 1.35 by updating the assertion for Deployment.Status.TerminatingReplicas to handle a behavioral change in the Kubernetes API.

• Updates the certs e2e test to use ptr.Deref for checking TerminatingReplicas instead of checking for nil
• Handles the k8s 1.35 change where TerminatingReplicas returns *int32(0) instead of nil when there are no terminating replicas

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[sohankunkerkar]

https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_kueue/8505/pull-kueue-test-integration-baseline-main/2009675285502365696

this looks like a flake to me.

[sohankunkerkar]

/test pull-kueue-test-integration-baseline-main

[mimowo]

this looks like a flake to me.

me too, let me open issue: #8507

[tenzen-y]

/cherry-pick release-0.14
/cherry-pick release-0.15

[k8s-infra-cherrypick-robot]

@tenzen-y: #8505 failed to apply on top of branch "release-0.14":

Applying: Fix certs e2e test for k8s 1.35
Using index info to reconstruct a base tree...
A	test/e2e/singlecluster/certs_test.go
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): test/e2e/singlecluster/certs_test.go deleted in HEAD and modified in Fix certs e2e test for k8s 1.35. Version Fix certs e2e test for k8s 1.35 of test/e2e/singlecluster/certs_test.go left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Fix certs e2e test for k8s 1.35

Details

In response to this:

/cherry-pick release-0.14
/cherry-pick release-0.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[tenzen-y]

@sohankunkerkar could you manually cherry-pick this into release-0.14 and 0.15?

[mimowo]

For 0.15 we don't need as #8499 already has it