Automated cherry pick of #8442: Support patching workload priority class

[ASverdlov]

Cherry pick of #8442 on release-0.15.

#8442: Support patching workload priority class

For details on the cherry pick process, see the cherry pick requests page.

Fix a bug that WorkloadPriorityClass value changes do not trigger Workload priority updates.

[k8s-ci-robot]

Hi @ASverdlov. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[netlify]

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name	Link
🔨 Latest commit	9d62d46
🔍 Latest deploy log	https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/69613e4fcbf483000849d79a

[mbobrovskyi]

/ok-to-test

[mbobrovskyi]

Is there are some conflicts?

[mbobrovskyi]

Ah, I see conflicts #8442 (comment). Sorry, missed this.

[tenzen-y]

We would appriciate if you can point the place where you manually fixed conflicts for reviewers 🙏

[ASverdlov]

@tenzen-y there were quite a few conflicts (10-20) related to refactoring of some testing frameworks, where I just accepted the old version.

Let me figure out the failures, and I'll document all the conflicts I've faced.

[tenzen-y]

@tenzen-y there were quite a few conflicts (10-20) related to refactoring of some testing frameworks, where I just accepted the old version.

Let me figure out the failures, and I'll document all the conflicts I've faced.

Thank you 👍

[ASverdlov]

Fixed the conflicts related to roletracker package not available in 0.15 manually, see the patch: https://gist.github.com/ASverdlov/9b195f2c8ed2c60932c4525825b4d5f9

Then rebased and force-pushed.

I still get the following error locally, but I don't see it in the CI failures, so I'm assuming something's wrong with my local setup:

=== Failed
=== FAIL: pkg/config TestConfigureClusterProfileCache/error_creating_CRD_client_with_empty_kubeConfig (0.03s)
    config.go:226: "level"=0 "msg"="Skipping MultiKueue ClusterProfile setup as the ClusterProfile CRD is not installed"
    config_test.go:1171: Expected error but got none

=== FAIL: pkg/config TestConfigureClusterProfileCache (0.09s)

[mimowo]

/kind bug
Thank you, I suggest you can try to cherrypick this one also to 0.14 if feasible (but starting from the commit for 0.15 already)

[mimowo]

So, IIUC conflicts where only around roletracker which are easy as shown by the diff, and the test files which are "safe", and also rather easy (eg the Slow annotation).

Thank you 👍
/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Details

Git tree hash: 3c470d323d9e401b948ce58501c3f3e874c68084

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ASverdlov, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [mimowo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ASverdlov]

/retest

[ASverdlov]

Thank you, I suggest you can try to cherrypick this one also to 0.14 if feasible (but starting from the commit for 0.15 already)

@mimowo thanks! Before I can cherry-pick it to 0.14, we need to cherry-pick #7289 to 0.14, since my changes depend on this PR.

[tenzen-y]

Thank you, I suggest you can try to cherrypick this one also to 0.14 if feasible (but starting from the commit for 0.15 already)

@mimowo thanks! Before I can cherry-pick it to 0.14, we need to cherry-pick #7289 to 0.14, since my changes depend on this PR.

@mimowo AFAIK, mutable WorkloadPriorityClass was introduced as part of v0.15.0. So, I think that this commit should be cherry-picked only to release-0.15.

[ASverdlov]

Looks like the cert e2e test is broken on 1.35 Kubernetes due to this change: https://github.com/kubernetes/kubernetes/pull/133087/files#diff-e91eb9863c89aa7f1f9dfa02c9e19af027bbb175057f55bd5628019d12bd5b16R339

I pushed the fix directly here. Let me see if it helps. Not sure why this doesn't fail anywhere else.

[ASverdlov]

This fix (9d62d46) helped. I'd like to create a separate PR with the same fix (and cherry-pick it to all supported versions), since this e2e test will be failed on all the new releases to k8s 1.35.

@mimowo lmk which order you prefer: waiting for that fix to land in release-0.15 first, or we can merge this cherry-pick PR and the fix commit together first

Update: I see someone was faster and already merged a fix to main: #8505, will wait for the cherry-pick and will rebase

[mimowo]

@mimowo AFAIK, mutable WorkloadPriorityClass was introduced as part of v0.15.0. So, I think that this commit should be cherry-picked only to release-0.15.

makes sense, thank you for checking

[mimowo]

This fix (9d62d46) helped. I'd like to create a separate PR with the same fix (and cherry-pick it to all supported versions), since this e2e test will be failed on all the new releases to k8s 1.35.

It is ok to embed in this PR as already done.

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Details

Git tree hash: 58e23e9df5c409792bc7d1e65fba830fb0dc4fb2