ci: skip deploy jobs until DEPLOY_ENABLED is set#21
Merged
Conversation
The Release workflow has failed on every main push since it landed: the deploy-staging job runs helm against an empty kubeconfig because no staging cluster (and no KUBE_CONFIG secret) exists yet. Gate deploy-staging and deploy-prod on the repository variable DEPLOY_ENABLED == 'true' so they show as skipped instead of failed, while image build + push to GHCR keeps running. When a cluster exists, enabling deploys is one variable plus the KUBE_CONFIG environment secret — documented in the workflow header and deploy/README.md. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Gates the Release workflow's deploy jobs behind a
DEPLOY_ENABLEDrepository variable so they skip cleanly instead of failing when no cluster is configured.Why
The Release workflow has failed on every push to
mainsince it landed (#18):deploy-stagingrunshelm upgradeagainst an empty kubeconfig because thestagingenvironment has noKUBE_CONFIGsecret — there's no staging cluster yet. The image build + push half of the workflow works fine; only the deploy half can't succeed. A permanently red workflow trains everyone to ignore CI.Changes
.github/workflows/release.yml:deploy-staginganddeploy-prodnow requirevars.DEPLOY_ENABLED == 'true'in addition to their existing ref conditions — without it they show as skipped and the workflow goes green, while images still build and push to GHCR on everymainpush andv*tagKUBE_CONFIGsecret)deploy/README.md: addedDEPLOY_ENABLEDto the "Required GitHub config" tableTo turn deploys on later: Settings → Secrets and variables → Actions → Variables →
DEPLOY_ENABLED=true, plus the base64 kubeconfig as theKUBE_CONFIGsecret on each environment. No workflow changes needed.Validated with
actionlint.🤖 Generated with Claude Code