Skip to content

feat: add FocusChin to guide toolbar v2 with dedicated controls for focus state#920

Merged
thomaswhyyou merged 10 commits intomainfrom
thomas-kno-12204-toolbar-beta-qa-and-feedback-items-6
Apr 1, 2026
Merged

feat: add FocusChin to guide toolbar v2 with dedicated controls for focus state#920
thomaswhyyou merged 10 commits intomainfrom
thomas-kno-12204-toolbar-beta-qa-and-feedback-items-6

Conversation

@thomaswhyyou
Copy link
Copy Markdown
Contributor

@thomaswhyyou thomaswhyyou commented Mar 30, 2026

Description

Adds a "FocusChin" component to the guide toolbar v2, which shows up when currently focused on a guide and has dedicated controls to move to the next or previous guide, or quit out of focus altogether.

This is more of an experiment based on this feedback, and will need inputs from Sam and Krisna.

Screenshots or videos

CleanShot.2026-03-31.at.15.27.56.mp4

@linear
Copy link
Copy Markdown

linear bot commented Mar 30, 2026

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 30, 2026

🦋 Changeset detected

Latest commit: 91adc51

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@knocklabs/react Patch
guide-example Patch
ms-teams-connect-example Patch
nextjs-app-dir-example Patch
nextjs-example Patch
slack-connect-example Patch
slack-kit-example Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 30, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
javascript-ms-teams-connect-example Ready Ready Preview, Comment Apr 1, 2026 6:24pm
javascript-nextjs-example Ready Ready Preview, Comment Apr 1, 2026 6:24pm
javascript-slack-connect-example Ready Ready Preview, Comment Apr 1, 2026 6:24pm
javascript-slack-kit-example Ready Ready Preview, Comment Apr 1, 2026 6:24pm

Request Review

@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-12204-toolbar-beta-qa-and-feedback-items-6 branch from d2c0d41 to dfec9cc Compare March 30, 2026 14:33
@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-12204-toolbar-beta-qa-and-feedback-items-5 branch from 1f8dc0a to fc8a78d Compare March 30, 2026 14:57
@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-12204-toolbar-beta-qa-and-feedback-items-6 branch from dfec9cc to d5f8a08 Compare March 30, 2026 14:57
@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-12204-toolbar-beta-qa-and-feedback-items-5 branch from fc8a78d to fa84159 Compare March 30, 2026 15:38
@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-12204-toolbar-beta-qa-and-feedback-items-6 branch 2 times, most recently from 6f81692 to c981a12 Compare March 30, 2026 15:54
@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-12204-toolbar-beta-qa-and-feedback-items-5 branch from fa84159 to 7644f64 Compare March 30, 2026 15:54
@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-12204-toolbar-beta-qa-and-feedback-items-6 branch from 86f94fb to e1b183b Compare March 30, 2026 20:52
@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-12204-toolbar-beta-qa-and-feedback-items-5 branch from b1c3441 to a8f7cae Compare March 30, 2026 20:59
@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-12204-toolbar-beta-qa-and-feedback-items-6 branch from e1b183b to 9da9e15 Compare March 30, 2026 20:59
@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-12204-toolbar-beta-qa-and-feedback-items-6 branch from 9da9e15 to a5f1892 Compare March 30, 2026 21:48
@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-12204-toolbar-beta-qa-and-feedback-items-5 branch from a8f7cae to 658c1c9 Compare March 30, 2026 21:48
@thomaswhyyou
Copy link
Copy Markdown
Contributor Author

@cursor review

@thomaswhyyou
Copy link
Copy Markdown
Contributor Author

@cursor review

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

</Box>

{/* Focus chin with dedicated controls */}
<FocusChin guides={guides} />
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Focus navigation uses filtered guide subset

Low Severity

FocusChin receives the already filtered guides list from V2.tsx, then computes previous/next from that subset. If focusedGuideKeys points to a guide no longer in the active filter (for example after live eligibility changes), currentKey is missing from selectableGuides, so both arrow controls become no-ops.

Additional Locations (2)
Fix in Cursor Fix in Web

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not an issue as we now unfocus if/when the currently focused guide becomes not visible in the new filtered list.

Copy link
Copy Markdown
Contributor

@connorlindsey connorlindsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cool! Could also just be via hotkey like arrow keys to cycle through and auto-focus guides

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

❌ Patch coverage is 10.83744% with 181 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.66%. Comparing base (6f079ff) to head (91adc51).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../modules/guide/components/Toolbar/V2/FocusChin.tsx 8.08% 125 Missing ⚠️
...act/src/modules/guide/components/Toolbar/V2/V2.tsx 5.26% 54 Missing ⚠️
...c/modules/guide/components/Toolbar/V2/GuideRow.tsx 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #920      +/-   ##
==========================================
- Coverage   64.61%   63.66%   -0.96%     
==========================================
  Files         207      208       +1     
  Lines        9711     9882     +171     
  Branches     1254     1254              
==========================================
+ Hits         6275     6291      +16     
- Misses       3411     3566     +155     
  Partials       25       25              
Files with missing lines Coverage Δ
...src/modules/guide/components/Toolbar/V2/helpers.ts 94.82% <ø> (ø)
...omponents/Toolbar/V2/useInspectGuideClientStore.ts 98.26% <100.00%> (+0.01%) ⬆️
...c/modules/guide/components/Toolbar/V2/GuideRow.tsx 6.25% <33.33%> (+0.28%) ⬆️
...act/src/modules/guide/components/Toolbar/V2/V2.tsx 7.21% <5.26%> (-0.38%) ⬇️
.../modules/guide/components/Toolbar/V2/FocusChin.tsx 8.08% <8.08%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants