Skip to content

better handling of focus error reason and message#913

Draft
thomaswhyyou wants to merge 2 commits intothomas-kno-12204-toolbar-beta-qa-and-feedback-itemsfrom
thomas-kno-12204-toolbar-beta-qa-and-feedback-items-2
Draft

better handling of focus error reason and message#913
thomaswhyyou wants to merge 2 commits intothomas-kno-12204-toolbar-beta-qa-and-feedback-itemsfrom
thomas-kno-12204-toolbar-beta-qa-and-feedback-items-2

Conversation

@thomaswhyyou
Copy link
Contributor

Description

** Describe what, why and how of the changes clearly and concisely. Add any additional useful context or info, as necessary. **

Todos

** List any todo items necessary before merging, if any. Delete if none. **

  • Sample todo item 1
  • Sample todo item 2

Checklist

  • Tests have been added for new features or major refactors to existing features.

Screenshots or videos

** Attach any screenshots or recordings to visually illustrate the changes, as necessary. Delete if not relevant. **

@linear
Copy link

linear bot commented Mar 27, 2026

@vercel
Copy link

vercel bot commented Mar 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
javascript-ms-teams-connect-example Ready Ready Preview, Comment Mar 27, 2026 3:15pm
javascript-nextjs-example Ready Ready Preview, Comment Mar 27, 2026 3:15pm
javascript-slack-connect-example Ready Ready Preview, Comment Mar 27, 2026 3:15pm
javascript-slack-kit-example Ready Ready Preview, Comment Mar 27, 2026 3:15pm

Request Review

@changeset-bot
Copy link

changeset-bot bot commented Mar 27, 2026

⚠️ No Changeset found

Latest commit: fdd38c4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor Author

thomaswhyyou commented Mar 27, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Mar 27, 2026

Codecov Report

❌ Patch coverage is 78.12500% with 7 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (thomas-kno-12204-toolbar-beta-qa-and-feedback-items@11e72bb). Learn more about missing BASE report.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...c/modules/guide/components/Toolbar/V2/GuideRow.tsx 14.28% 6 Missing ⚠️
...act/src/modules/guide/components/Toolbar/V2/V2.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                                  Coverage Diff                                   @@
##             thomas-kno-12204-toolbar-beta-qa-and-feedback-items     #913   +/-   ##
======================================================================================
  Coverage                                                       ?   65.20%           
======================================================================================
  Files                                                          ?      207           
  Lines                                                          ?     9614           
  Branches                                                       ?     1254           
======================================================================================
  Hits                                                           ?     6269           
  Misses                                                         ?     3320           
  Partials                                                       ?       25           
Files with missing lines Coverage Δ
...src/modules/guide/components/Toolbar/V2/helpers.ts 94.82% <100.00%> (ø)
...omponents/Toolbar/V2/useInspectGuideClientStore.ts 98.25% <100.00%> (ø)
...act/src/modules/guide/components/Toolbar/V2/V2.tsx 7.16% <0.00%> (ø)
...c/modules/guide/components/Toolbar/V2/GuideRow.tsx 5.44% <14.28%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant