chore(web): cleanup web/src/app/browser/src/test-index.ts exports 🍒#16038
Draft
mcdurdin wants to merge 2 commits into
Draft
Conversation
The export of `test-index.ts` were intended to be used by tests only, but over time they contained also exports that were consumed else where, e.g. in UI classes like `kmwuibutton.ts`. This change removes unused exports, moves test-only classes to a `unitTestEndPoints` container and marks test-only types with `@internal`. Build-bot: skip build:web Test-bot: skip
The convention is to use the `.d.ts` extension for typescript types, and that's what is used elsewhere in the `package.json` file. This change fixes the two instances that had `.d.js`.
User Test ResultsTest specification and instructions User tests are not required |
github-actions
Bot
added
web/
cherry-pick
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replay onto chore/web-core-preflight for merge to alpha.
Cherry-pick-of: #15899
Test-bot: skip