chore: web-core preflight#16015
Draft
mcdurdin wants to merge 472 commits into
Draft
Conversation
refactor(web): rename OutputTarget related classes 🎼 Rename the OutputTarget related classes to better communicate what they are doing - they are interfacing with the text and thus roughly correspond to the TextStore on desktop platforms.
refactor(web): extract minimal TextStore interface that LanguageProcessor can use 🎼
…wngrade-web-utils-from-package-to-module
This change replaces the default export of ContextManager with a regular export. Test-bot: skip
…actor/web/downgrade-web-utils-from-package-to-module
…dules refactor(web): merge engine modules 🎼
refactor(web): change default export of ContextManager 🎼
sentry-manager is used by Keyman Engine for Android and Keyman Engine for iOS, but not directly by KeymanWeb, nor does it have any dependencies on /web. So it does not make sense to keep it under /web. es-bundling is used by sentry-manager and potentially other /common/web tools in the future, so moving it under /common/tools makes it more consistent in the future. This is part of simplifying the web source tree; these changes do not make significant build performance differences at this time. Test-bot: skip
…ores refactor(web): remove duplicate element-text-stores folder 🎼
chore(web): apply suggestions from code review 🎼
…ance * Simplify the build dependency / child tree * Split building and testing tooling so we don't rebuild components * Fixup expected outputs to avoid repeated builds of components * Remove unused dependency references * Move test.sh targets into build.sh, so that testing doesn't lose dependency tracking and cause unnecessary rebuilds. (Note that I have not yet deleted test.sh.) * Make predictive-text a direct child of engine, so that we don't build it twice (or even more times) Test-bot: skip
…refactor/web/downgrade-web-utils-from-package-to-module
After review with @ermshiperete, we decided to remove this. It is unclear to me why we were ever clearing the context when a beep was triggered by the keyboard. This is legacy from v2.0 of KeymanWeb, and I suspect it's an edge case that no one has ever noticed, but I can't see a reason to keep it. Test-bot: skip
…tils-from-package-to-module refactor(web): change @keymanapp/web-utils to keyman/common/web-utils 🎼
…o-web-core auto: A19S15 merge master into web-core 🎼
…to-common-web refactor(web): move sentry-manager and es-bundling to common 🎼
…ith-beep fix(web): don't reset context cache with beep 🎼
maint(web): cleanup web/**/build.sh for consistency and build performance 🎼
Meson 1.1 changed the name of the options file from `meson_options.txt` to `meson.options`. Currently we're stuck with Meson 1.0 as minimum Meson version because we still support Ubuntu 22.04 Jammy, but on some machines a newer version of meson gets installed which causes the options to be ignored. The first attempt to simply symlink or copy `meson_options.txt` to `meson.options` failed because git on Windows doesn't support symlinks by default, and Meson complains if it finds two options files (#15127). Fortunately not having an options file is only a problem for Core where we have one option in the options file that defaults to true. The solution implemented in this change is to always pass the option to Meson. Cherry-pick-of: #15131 Test-bot: skip
Also renames internal `_dks` to `_deadkeys`. Test-bot: skip
The file sneaked in through a merge/rebase. Build-bot: skip Test-bot: skip
- initialize `Deadkey.matched` in c'tor - fix `Deadkey.equal` method - verify deadkey exists before removing it in `DeadkeyTracker.remove` - add unit tests for DeadkeyTracker Test-bot: skip
This allows to use `console.log(deadkey.toString())` to get the values of a deadkey. Test-bot: skip
keymanapp-test-bot
Bot
added
the
user-test-missing
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
Member
Author
keymanapp-test-bot
Bot
removed
the
user-test-missing
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Investigative PR; do not merge
Build-bot: skip release:all
Test-bot: skip