maint(web): fix running web e2e tests on Windows 🎼 🍒#16032
Draft
mcdurdin wants to merge 2 commits into
Draft
Conversation
This change outputs the name of the TC reporter used for a test. This will help in troubleshooting. Build-bot: skip build:web Test-bot: skip
Starting the local dev server before running the e2e tests with `web/build.sh start` didn't work on Windows. This change now directly calls `node` to start the server which seems to work cross-platform. Fixes: #15895 Build-bot: skip build:web Test-bot: skip
github-actions
Bot
added
web/
common/
cherry-pick
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replay onto chore/web-core-preflight for merge to alpha.
Cherry-pick-of: #15949
Test-bot: skip