Skip to content

Add fast-growing-international-products skill#13

Open
norightsforlis wants to merge 2 commits into
joomcode:mainfrom
norightsforlis:add-fast-growing-international-products
Open

Add fast-growing-international-products skill#13
norightsforlis wants to merge 2 commits into
joomcode:mainfrom
norightsforlis:add-fast-growing-international-products

Conversation

@norightsforlis

Copy link
Copy Markdown
Contributor

Summary

Adds the fast-growing-international-products skill: Finds fast-growing international (imported) products across all categories as one table, each tagged with its category.

Lives in skills/fast-growing-international-products/SKILL.md and is registered in the README skills table. Public behavior and user-visible workflow only — no internal service names, schema, or implementation details.

Public-Safety Checklist

  • No credentials, tokens, keys, or secrets.
  • No internal filesystem paths.
  • No private Slack, Jira, Notion, admin, or service URLs.
  • No private service names or implementation details.
  • No customer data or private product data.
  • Skill directory name matches SKILL.md frontmatter name.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@profunctor

Copy link
Copy Markdown
Collaborator

KISS review: two behavior issues to fix before merge.

  1. The skill allows “top items by estimated weekly revenue” as a fast-growth rule, but revenue alone is not growth and can surface old/high-ticket slow movers as “taking off.” Please require a real momentum proxy, e.g. low time on air + strong estimated weekly sales/revenue.
  2. The skill tells agents to hand off to the “single-category international skill” and international-product-matcher, but those skills are not present in this PR. Please remove those handoffs or add the actual skills/names in this PR.

@profunctor

Copy link
Copy Markdown
Collaborator

Review — fast-growing-international-products

Summary: A marketwide skill that uses JoomPulse to surface fast-growing international/imported products across all Mercado Livre (Brasil) categories, returned as one markdown table with a Category column plus price, est. weekly sales/revenue, rating, time-on-air, logistics, listing type, and seller medal, with the estimate disclaimer and optional cards/charts.

Findings:

  • major — Dangling references to two non-existent sibling skills ("single-category international skill", "international-product-matcher skill"). The agent is instructed to hand off to skills that aren't installed. Add the siblings or soften the references.
  • major — "JoomPro" is named as the import target ("match items to a specific JoomPro product for import"). JoomPro is a separate Joom B2B venture and appears nowhere else in this public catalog; the PR's own public-safety checklist claims "no private service names." Please confirm this is cleared for public exposure, or remove/genericize it.
  • minor — "Fast growth" is left entirely to the agent ("there is no single fast-growth flag... define it pragmatically"), so two runs can produce very different lists. Consider a recommended default rule for reproducibility.
  • nit — Frontmatter description is long and front-loads ALL-CAPS emphasis; trimming the cross-skill handoff text would tighten triggering.
  • nit — Disclaimer is pt-BR only, while ml-product-analysis ships a bilingual EN/pt-BR disclaimer; an English-speaking seller would get a Portuguese disclaimer.

No broken queries, credentials, internal paths, or write operations; read-only and discovery is convention-based (no manifest change needed). Blockers are the first two findings.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants