Skip to content

Add popular-international-products skill#12

Open
norightsforlis wants to merge 1 commit into
joomcode:mainfrom
norightsforlis:add-popular-international-products
Open

Add popular-international-products skill#12
norightsforlis wants to merge 1 commit into
joomcode:mainfrom
norightsforlis:add-popular-international-products

Conversation

@norightsforlis

Copy link
Copy Markdown
Contributor

Summary

Adds the popular-international-products skill: Finds fast-growing international (imported) products in one category, with a JoomPulse link per item and a JoomPro sourcing pointer.

Lives in skills/popular-international-products/SKILL.md and is registered in the README skills table. Public behavior and user-visible workflow only — no internal service names, schema, or implementation details.

Public-Safety Checklist

  • No credentials, tokens, keys, or secrets.
  • No internal filesystem paths.
  • No private Slack, Jira, Notion, admin, or service URLs.
  • No private service names or implementation details.
  • No customer data or private product data.
  • Skill directory name matches SKILL.md frontmatter name.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@profunctor

Copy link
Copy Markdown
Collaborator

KISS review: this skill currently promises “fast-growing” imported products, but the workflow allows ranking by plain estimated weekly revenue when no growth signal exists. That can mislead sellers: high-revenue incumbents are not necessarily growing products.

Please either:

  1. rename/position the skill as “popular/top international products”, or
  2. require a real growth rule and remove the revenue-only fallback.

Also please remove the handoffs to all-categories international skill and international-product-matcher until those skills are shipped, and avoid a per-row JoomPro column if every row links to the same generic search page.

@profunctor

Copy link
Copy Markdown
Collaborator

Review — popular-international-products

Summary: Given one Mercado Livre (Brasil) category, uses JoomPulse to find fast-growing international/imported listings, ranks by recent momentum, and returns a ~10-row product table (price, est. weekly sales/revenue, rating, reviews, time on air, shipping, listing type, seller medal, per-item JoomPulse link, and a general JoomPro search link). Read-only, pt-BR default.

Findings:

  • major — Dangling references to non-existent siblings ("all-categories international skill", "international-product-matcher skill"). Drop them or land the referenced skills first.
  • major — Unverifiable "international/imported" filter. The skill hinges on JoomPulse flagging listings as cross-border, but Prerequisites only assume this exists without a concrete field/query path. If no such flag exists the skill silently can't do its core job. Define how "international" is determined and add a "no international flag available" guardrail.
  • minor — "Fast-growing" is left to the model to define (recency vs weekly revenue), so output isn't repeatable. Pin a default rule while still disclosing it.
  • nit — Hardcoded https://joom.pro/pt-br/search link for every item is static and locale-pinned (not item-specific); adds little and will rot if the path changes. (Also: confirm JoomPro is OK to name publicly — see Add fast-growing-international-products skill #13.)
  • nit — Disclaimer is pt-BR only, inconsistent with the bilingual sibling disclaimers.

README row, frontmatter name == directory, section structure, and guardrails all match. No secrets or write operations. Findings 1–2 are the blockers.

@norightsforlis

Copy link
Copy Markdown
Contributor Author

Thanks for the careful review, @profunctor — replying on the international/imported filter point (finding #2).

The filter isn't actually unanchored. The skill relies on a concrete per-listing signal that JoomPulse exposes — whether a listing is international (imported / cross-border) — and filters on it within JoomPulse. The skill never calls the Mercado Livre API.

It reads as vague in SKILL.md on purpose: per CONTRIBUTING's public-safety rules (no private service names / implementation details), I kept the description behavioral ("flagged as cross-border") instead of naming the underlying field.

Your point still stands that the public text should be concrete and have a fallback, so I'll tighten it to:

  • Workflow: "Use JoomPulse to get the category's active listings and keep only those JoomPulse flags as international (imported / cross-border)."
  • Prerequisites: "…the available JoomPulse tools can return a category's active listings and indicate which are international (imported / cross-border)."
  • Guardrail (Notes): "If JoomPulse doesn't expose an international flag for the category's listings, say so plainly and stop — don't pass off ordinary listings as imported."

That keeps the internal field name out (public-safety) while making the mechanism explicit and adding the missing guardrail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants