Skip to content

Revise SVS_CHECK_BOUNDS logic #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ethanglaser merged 1 commit into from
Mar 25, 2026
Merged

Revise SVS_CHECK_BOUNDS logic #301

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions cmake/options.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,18 @@ option(SVS_EXPERIMENTAL_CLANG_TIDY
OFF # disabled by default
)

option(SVS_EXPERIMENTAL_CHECK_BOUNDS
"Enable bounds checking on many data accesses."
OFF # diabled by default
)
# If not explicitly set by user, check bounds for non-release builds
if (CMAKE_BUILD_TYPE STREQUAL "Release")
option(SVS_EXPERIMENTAL_CHECK_BOUNDS
"Enable bounds checking on many data accesses."
OFF
)
else()
option(SVS_EXPERIMENTAL_CHECK_BOUNDS
"Enable bounds checking on many data accesses."
ON
)
endif()

option(SVS_EXPERIMENTAL_ENABLE_NUMA
"Enable NUMA aware data structures. (Experimental)"
Expand Down Expand Up @@ -126,8 +134,7 @@ if (SVS_NO_AVX512)
target_compile_options(${SVS_LIB} INTERFACE -mno-avx512f)
endif()

# Enable bounds-checking by default for non-release builds.
if (SVS_EXPERIMENTAL_CHECK_BOUNDS OR NOT CMAKE_BUILD_TYPE STREQUAL "Release")
if (SVS_EXPERIMENTAL_CHECK_BOUNDS)
target_compile_definitions(${SVS_LIB} INTERFACE -DSVS_CHECK_BOUNDS=1)
else()
target_compile_definitions(${SVS_LIB} INTERFACE -DSVS_CHECK_BOUNDS=0)
Expand Down
Loading