Skip to content

Revise SVS_CHECK_BOUNDS logic#301

Merged
ethanglaser merged 1 commit intomainfrom
dev/eglaser-check-bounds-fix
Mar 25, 2026
Merged

Revise SVS_CHECK_BOUNDS logic#301
ethanglaser merged 1 commit intomainfrom
dev/eglaser-check-bounds-fix

Conversation

@ethanglaser
Copy link
Member

@ethanglaser ethanglaser commented Mar 24, 2026

  • Refactors SVS_CHECK_BOUNDS logic so that explicitly passing SVS_EXPERIMENTAL_CHECK_BOUNDS will trump any other settings, but not explicitly passing will lead to SVS_CHECK_BOUNDS depending on CMAKE_BUILD_TYPE
  • Previously, non-Release builds would force bounds checking on even when a user explicitly passed -DSVS_EXPERIMENTAL_CHECK_BOUNDS=OFF, but this now changes - see table below for more details
  • Updates docs to reflect the conditional default

SVS_CHECK_BOUNDS value (current behavior)
image

SVS_CHECK_BOUNDS value (updated behavior)
image

@ethanglaser ethanglaser marked this pull request as ready for review March 24, 2026 20:06
@ethanglaser ethanglaser merged commit 4c831ff into main Mar 25, 2026
26 of 27 checks passed
@ethanglaser ethanglaser deleted the dev/eglaser-check-bounds-fix branch March 25, 2026 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants