Uses one build for bower, npm, and global builds#26
Open
jeffkole wants to merge 1 commit intoinstructure-react:masterfrom
Open
Uses one build for bower, npm, and global builds#26jeffkole wants to merge 1 commit intoinstructure-react:masterfrom
jeffkole wants to merge 1 commit intoinstructure-react:masterfrom
Conversation
|
Looking forward to see that merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Take a look at this possible solution to the "one build to bind them" problem. The changes that matter are in
package.json,bower.json, andscript/build. The rest is just committed generated source files.I think this should work, though without being able to properly release it, I can't really test it out.
The most controversial part of this may be that I changed the
mainattribute inpackage.jsonto point to thedist/lib/index.jsfile. If the release process callednpm publish distinstead of justnpm publish, we would not need to do that.