Adds a CommonJS build script#23
Conversation
This works for me, because I am pushing these CommonJS builds to my own Github repo. If we wanted a proper CommonJS distribution, then it would need to be published to npm.
|
@jeffkole thanks for this, I like it. I wonder if it wouldn't be better to combine this into a single build and a single release (or at least have a single command for each). i can see a future issue where only globals get built and released (or only the commonjs version). thoughts? |
|
One build and release script is definitely better. The current one is fairly specialized (ie, works great with Browserify and if you are including React globally), so I didn't want mess with it, because I do not know the project history. I mostly stole my solution from what I saw from @ryanflorence in rackt/react-router. It is possible that the CommonJS solution can also work just fine for the Browserify case you had targeted originally. |
|
yeah, i think it can. we can ditch the browserify solution if we can make something that will work for:
|
|
#26 may fit the bill better. |
2 participants
This is a start at an attempt to produce a CommonJS build in response to my question yesterday: #22. Let me know what you think.