refactor: Rename normalization flags to normalized - #2862
Open
krlmlr wants to merge 1 commit into
Open
Conversation
`power_centrality(rescale = )`, `hits_scores(scale = )` and `tk_coords(norm = )` unify on `normalized`, matching the nine functions that already use that name. Legacy spellings are soft-deprecated. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RTPj4qNv2FWui6etixZeuR
Contributor
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if f27a205 is merged into claude/issue-2788-subagents-faw1t1-3:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #2788 (PR 4 of the stack, on top of #2861); executes the "normalized" row of the survey — nine functions already spell this flag
normalized, and these are the three stragglers.What this does
power_centrality():rescale→normalized(pure registry rename; the arg sits after...).tk_coords():norm→normalized(pure registry rename). Abbreviationsn/no/nornow reject as ambiguous between the two spellings; the retired exactnorm =is recovered with the soft-deprecation.hits_scores():scale→normalized. This function uses the strictcheck_dots_empty()style (no registry entry), so the rename keeps a trailingscale = deprecated()sentinel with an in-body bridge: soft-deprecation, value forwarded, and an error when both spellings are supplied. The soft-deprecatedhub_score()/authority_score()keep their frozenscaleformals and forward tonormalized; same forbonpow()(rescale) andtkplot.getcoords()(norm), each with a local deprecated-badge@paramwhere@inheritParamsno longer covers the old name.Deliberately untouched
eigen_centrality(scale = ),centr_eigen(scale = ),centr_eigen_tmax(scale = )— already-neutereddeprecated()formals (normalization is always on); nothing to rename.rescaleinplot.igraph()and the embedding functions'scaled— different semantics.🤖 Generated with Claude Code
https://claude.ai/code/session_01RTPj4qNv2FWui6etixZeuR
Generated by Claude Code