refactor: Purge legacy alias formals via the migration registry - #2863
Open
krlmlr wants to merge 1 commit into
Open
refactor: Purge legacy alias formals via the migration registry#2863krlmlr wants to merge 1 commit into
krlmlr wants to merge 1 commit into
Conversation
`layout_with_fr(maxiter = )` folds into the registry as a rename to `niter` (the alias was silent before, now it soft-deprecates), `layout_with_kk(start = )` gains its missing soft-deprecation, `cluster_leiden()` joins the registry with `resolution_parameter` recovered as `resolution`, and the long-dead `neimode`/`father` formals and result aliases of `bfs()`/`dfs()` are removed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RTPj4qNv2FWui6etixZeuR
Contributor
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if e79a7b8 is merged into claude/issue-2788-subagents-faw1t1-4:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #2788 (PR 5 of the stack, on top of #2862); answers the survey's "migrate the existing hand-rolled alias formals into the registry" question for the aliases that are ready, so the signatures shrink to canonical names.
What this does
layout_with_fr(): the trailingmaxiter = deprecated()formal disappears; the registry now recoversmaxiter =as a rename toniter. This alias was bridged silently before (no deprecation signal at all) — it now gets the standard 3.0.0 soft-deprecation.layout_with_kk():start(alias ofcoords) cannot ride the registry becausecoordsis a head formal, so the sentinel formal stays — but the bridge now emits the previously missingdeprecate_soft()(it was a silent alias too), and the@paramgains its deprecated badge.cluster_leiden(): gains its missing registry entry (it was the onlycluster_*()without one, still on strictcheck_dots_empty()). Theresolution_parameter = deprecated()formal and hand bridge are removed; the registry recovers it as a rename toresolution. Theoldentry reproduces the true v2.0.0 positional signature (verified against thev2.0.0tag, commit8102f30, whereresolution_parameterwas canonical slot 4), so both 2.0-era positional calls and 2.1-era keyword calls recover correctly.bfs()/dfs(): theneimode/fathertrailing formals — harddeprecate_stop()errors since 1.3.0/2.2.0 — are removed, together with theres$neimode <- res$modeandres$father <- res$parentreturn-value aliases (marked "Remove in 1.4.0" in the source). Calls using the dead names now failcheck_dots_empty()(`...` must be empty) instead of the bespoke stop message. Thegraph.bfs()/graph.dfs()wrappers needed their unconditionalneimodeforwards dropped to keep working; their still-functionalfather→parentmapping is untouched.Deliberately left for a follow-up
make_lattice()/lattice()circular→periodic: these functions have no ellipsis migration yet; the alias should ride that migration when it happens (note the knowndim/dimvectorprefix hazard documented in the generator fixture).eigen_centrality()/centr_eigen()/centr_eigen_tmax()scale = deprecated(): dropped functionality (normalization is always on), not aliases — nothing to recover; removal is a later deprecation-advancement step (write code to advance lifecycle deprecations #1121).layout_with_fr()/layout_with_kk()zombie formals (coolexp,maxdelta,area,repulserad,sigma,initemp,niter-on-kk) — hard-stopped since 0.8.0; same advancement track. Theniter/maxiterrole swap between fr and kk remains a naming wart for the iterations-family decision in Comprehensive plan: argument renames for 3.0.0 #2788.🤖 Generated with Claude Code
https://claude.ai/code/session_01RTPj4qNv2FWui6etixZeuR
Generated by Claude Code