-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Use releaseTag with fallback to downloadUrl in updates.xml #3713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
christophwille
wants to merge
5
commits into
master
Choose a base branch
from
christophwille/UpdateUrlViaReleaseTag
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a6ab47a
Use releaseTag with fallback to downloadUrl in updates.xml
christophwille cb9f10e
Add tests
christophwille bc674b2
Prevent arbitrary downloadUrl - must start with BaseUrl as well
christophwille 53a0549
Remove custom domain ilspy.net in end-user visible places
christophwille 1e5ddf3
Fix xml root node
christophwille File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,109 @@ | ||
| using System; | ||
| using System.Net; | ||
| using System.Net.Http; | ||
| using System.Threading; | ||
| using System.Threading.Tasks; | ||
|
|
||
| using AwesomeAssertions; | ||
|
|
||
| using ICSharpCode.ILSpy.Updates; | ||
|
|
||
| using NUnit.Framework; | ||
|
|
||
| namespace ICSharpCode.ILSpy.Tests; | ||
|
|
||
| [TestFixture] | ||
| public class UpdateServiceTests | ||
| { | ||
| [Test] | ||
| public async Task GetLatestVersionAsync_UsesReleaseTag_WhenReleaseTagIsPresent() | ||
| { | ||
| const string xml = """ | ||
| <updateInfo> | ||
| <band id="stable"> | ||
| <latestVersion>10.0.0.0</latestVersion> | ||
| <releaseTag>v10.0</releaseTag> | ||
| <downloadUrl>https://example.com/ignored.zip</downloadUrl> | ||
| </band> | ||
| </updateInfo> | ||
| """; | ||
|
|
||
| using var client = new HttpClient(new StubHttpMessageHandler(xml)); | ||
|
|
||
| var result = await UpdateService.GetLatestVersionAsync(client, new Uri("https://example.com/updates.xml")); | ||
|
|
||
| result.Version.Should().Be(new Version(10, 0, 0, 0)); | ||
| result.DownloadUrl.Should().Be("https://github.com/icsharpcode/ILSpy/releases/tag/v10.0"); | ||
| } | ||
|
|
||
| [Test] | ||
| public async Task GetLatestVersionAsync_ReturnsNullDownloadUrl_WhenReleaseTagContainsPathTraversalAttempt() | ||
| { | ||
| const string xml = """ | ||
| <updateInfo> | ||
| <band id="stable"> | ||
| <latestVersion>10.0.0.0</latestVersion> | ||
| <releaseTag>../malicious</releaseTag> | ||
| <downloadUrl>https://example.com/ignored.zip</downloadUrl> | ||
| </band> | ||
| </updateInfo> | ||
| """; | ||
|
|
||
| using var client = new HttpClient(new StubHttpMessageHandler(xml)); | ||
|
|
||
| var result = await UpdateService.GetLatestVersionAsync(client, new Uri("https://example.com/updates.xml")); | ||
|
|
||
| result.Version.Should().Be(new Version(10, 0, 0, 0)); | ||
| result.DownloadUrl.Should().BeNull(); | ||
| } | ||
|
|
||
| [Test] | ||
| public async Task GetLatestVersionAsync_UsesDownloadUrl_WhenReleaseTagIsMissing() | ||
| { | ||
| const string xml = """ | ||
| <updateInfo> | ||
| <band id="stable"> | ||
| <latestVersion>10.0.0.0</latestVersion> | ||
| <downloadUrl>https://github.com/icsharpcode/ILSpy/releases/tag/v10.0</downloadUrl> | ||
| </band> | ||
| </updateInfo> | ||
| """; | ||
|
|
||
| using var client = new HttpClient(new StubHttpMessageHandler(xml)); | ||
|
|
||
| var result = await UpdateService.GetLatestVersionAsync(client, new Uri("https://example.com/updates.xml")); | ||
|
|
||
| result.Version.Should().Be(new Version(10, 0, 0, 0)); | ||
| result.DownloadUrl.Should().Be("https://github.com/icsharpcode/ILSpy/releases/tag/v10.0"); | ||
| } | ||
|
|
||
| [Test] | ||
| public async Task GetLatestVersionAsync_UsesDownloadUrl_ButFailsBecauseBaseUrlDoesntMatch() | ||
| { | ||
| const string xml = """ | ||
| <updateInfo> | ||
| <band id="stable"> | ||
| <latestVersion>10.0.0.0</latestVersion> | ||
| <downloadUrl>https://example.com/ilspy.zip</downloadUrl> | ||
| </band> | ||
| </updateInfo> | ||
| """; | ||
|
|
||
| using var client = new HttpClient(new StubHttpMessageHandler(xml)); | ||
|
|
||
| var result = await UpdateService.GetLatestVersionAsync(client, new Uri("https://example.com/updates.xml")); | ||
|
|
||
| result.Version.Should().Be(new Version(10, 0, 0, 0)); | ||
| result.DownloadUrl.Should().BeNull(); | ||
| } | ||
|
|
||
| sealed class StubHttpMessageHandler(string responseContent) : HttpMessageHandler | ||
| { | ||
| protected override Task<HttpResponseMessage> SendAsync(HttpRequestMessage request, CancellationToken cancellationToken) | ||
| { | ||
| return Task.FromResult(new HttpResponseMessage(HttpStatusCode.OK) { | ||
| Content = new StringContent(responseContent) | ||
| }); | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.