Use releaseTag with fallback to downloadUrl in updates.xml#3713
Open
christophwille wants to merge 5 commits intomasterfrom
Open
Use releaseTag with fallback to downloadUrl in updates.xml#3713christophwille wants to merge 5 commits intomasterfrom
christophwille wants to merge 5 commits intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates ILSpy’s update-check parsing to support a new releaseTag field in updates.xml (per #3707), enabling update links to be constructed from GitHub release tags with a fallback to the legacy downloadUrl.
Changes:
- Add support for
<releaseTag>inUpdateService, constructing a GitHub releases/tag URL and falling back to<downloadUrl>when missing. - Refactor update fetching to allow dependency injection of
HttpClient/URL for testing. - Add NUnit tests covering
releaseTagbehavior and wire the new test file into the test project.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ILSpy/Updates/UpdateService.cs | Parses releaseTag and builds the GitHub tag URL; adds injectable overload for testability. |
| ILSpy.Tests/UpdateServiceTests.cs | Adds unit tests validating releaseTag handling and fallback behavior. |
| ILSpy.Tests/ILSpy.Tests.csproj | Includes the new test file in the explicit compile item list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #3707
Would need modification to
ILSpy/updates.xml
Line 4 in 5081163