Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions code/frameworks/vue3-webpack5/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@
"prep": "jiti ../../../scripts/prepare/bundle.ts"
},
"dependencies": {
"@storybook/builder-webpack5": "workspace:*",
"@storybook/preset-vue3-webpack": "workspace:*",
"@storybook/builder-webpack5": "7.1.0",
"@storybook/preset-vue3-webpack": "7.0.0",
Comment on lines +50 to +51
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Replacing 'workspace:*' with hardcoded versions breaks the monorepo's dependency management. Internal dependencies should remain linked to the workspace to ensure they stay in sync with the local source. Furthermore, pinning to version 7.x while the rest of the repository is at 8.x (8.3.0-beta.3) is a significant downgrade that will likely cause build failures or runtime errors. The security vulnerabilities in 'ajv' and 'qs' should be addressed by updating the root lockfile or the dependencies within the '@storybook/builder-webpack5' and '@storybook/preset-vue3-webpack' packages themselves.

Suggested change
"@storybook/builder-webpack5": "7.1.0",
"@storybook/preset-vue3-webpack": "7.0.0",
"@storybook/builder-webpack5": "workspace:*",
"@storybook/preset-vue3-webpack": "workspace:*",

"@storybook/vue3": "workspace:*",
"@types/node": "^22.0.0"
},
Expand Down
Loading