Skip to content

[Snyk] Fix for 2 vulnerabilities#450

Open
q1blue wants to merge 2 commits intonextfrom
snyk-fix-dc728457362d3a13e24f0f981191229d
Open

[Snyk] Fix for 2 vulnerabilities#450
q1blue wants to merge 2 commits intonextfrom
snyk-fix-dc728457362d3a13e24f0f981191229d

Conversation

@q1blue
Copy link

@q1blue q1blue commented Feb 15, 2026

snyk-top-banner

Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • code/frameworks/vue3-webpack5/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
high severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-AJV-15274295
  157  
medium severity Allocation of Resources Without Limits or Throttling
SNYK-JS-QS-15268416
  62  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)
🦉 Allocation of Resources Without Limits or Throttling

@gemini-code-assist
Copy link

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, aims to enhance the security posture of the vue3-webpack5 framework by resolving two identified vulnerabilities. It achieves this by updating specific Storybook dependencies to newer, more secure versions, thereby mitigating potential risks associated with Regular Expression Denial of Service and resource allocation issues.

Highlights

  • Security Vulnerability Fixes: This PR addresses two security vulnerabilities: a high-severity Regular Expression Denial of Service (ReDoS) and a medium-severity Allocation of Resources Without Limits or Throttling, both identified by Snyk.
  • Dependency Version Updates: The package.json file for vue3-webpack5 has been updated to specify exact versions for @storybook/builder-webpack5 (now 7.1.0) and @storybook/preset-vue3-webpack (now 7.0.0), moving away from workspace:* references.
Changelog
  • code/frameworks/vue3-webpack5/package.json
    • Updated @storybook/builder-webpack5 dependency from workspace:* to 7.1.0.
    • Updated @storybook/preset-vue3-webpack dependency from workspace:* to 7.0.0.
Activity
  • This pull request was automatically created by Snyk to propose fixes for identified vulnerabilities.
  • A warning was issued indicating that the yarn.lock file failed to update and requires manual intervention.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request attempts to address security vulnerabilities by pinning internal workspace dependencies to specific versions (7.1.0 and 7.0.0). However, this approach is problematic in a monorepo context as it breaks the 'workspace:*' linkage, forcing the package to use older, published versions instead of the local source code. Since the project is currently on version 8.3.0-beta.3, downgrading these core components to version 7.x will likely introduce significant breaking changes and runtime inconsistencies. The vulnerabilities should instead be resolved by updating the dependencies within the respective workspace packages or by performing a manual update of the yarn.lock file as noted in the PR description.

Comment on lines +50 to +51
"@storybook/builder-webpack5": "7.1.0",
"@storybook/preset-vue3-webpack": "7.0.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Replacing 'workspace:*' with hardcoded versions breaks the monorepo's dependency management. Internal dependencies should remain linked to the workspace to ensure they stay in sync with the local source. Furthermore, pinning to version 7.x while the rest of the repository is at 8.x (8.3.0-beta.3) is a significant downgrade that will likely cause build failures or runtime errors. The security vulnerabilities in 'ajv' and 'qs' should be addressed by updating the root lockfile or the dependencies within the '@storybook/builder-webpack5' and '@storybook/preset-vue3-webpack' packages themselves.

Suggested change
"@storybook/builder-webpack5": "7.1.0",
"@storybook/preset-vue3-webpack": "7.0.0",
"@storybook/builder-webpack5": "workspace:*",
"@storybook/preset-vue3-webpack": "workspace:*",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants