Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion code/frameworks/vue3-vite/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
"prep": "jiti ../../../scripts/prepare/bundle.ts"
},
"dependencies": {
"@storybook/builder-vite": "workspace:*",
"@storybook/builder-vite": "0.1.22",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change from workspace:* to a pinned version 0.1.22 is incorrect for this monorepo setup. The workspace:* protocol ensures that the local version of @storybook/builder-vite from this repository is used. Pinning to 0.1.22 will instead fetch a very old, published version from the registry, which is a significant downgrade from the current workspace version (8.3.0-beta.3). This will likely break the build or lead to unexpected behavior by using an incompatible, outdated version of the builder. The security vulnerability should be addressed within the @storybook/builder-vite package itself, not by breaking the workspace linkage.

Suggested change
"@storybook/builder-vite": "0.1.22",
"@storybook/builder-vite": "workspace:*",

"@storybook/vue3": "workspace:*",
"find-package-json": "^1.2.0",
"magic-string": "^0.30.0",
Expand Down
Loading