[Snyk] Security upgrade @storybook/builder-vite from 0.0.0-use.local to 0.1.22#446
[Snyk] Security upgrade @storybook/builder-vite from 0.0.0-use.local to 0.1.22#446
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-QS-15268416
Summary of ChangesHello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automates a critical security upgrade for the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request, automatically generated by Snyk, aims to fix a security vulnerability by upgrading @storybook/builder-vite. However, the proposed change is incorrect and will likely break the project. It replaces a workspace:* dependency with a pinned, outdated version (0.1.22), which goes against the monorepo structure where packages are intended to use their local counterparts. This constitutes a major downgrade and will cause inconsistencies. The change should be rejected, and the vulnerability should be addressed by updating the dependencies within the @storybook/builder-vite package itself while preserving the workspace link.
| }, | ||
| "dependencies": { | ||
| "@storybook/builder-vite": "workspace:*", | ||
| "@storybook/builder-vite": "0.1.22", |
There was a problem hiding this comment.
This change from workspace:* to a pinned version 0.1.22 is incorrect for this monorepo setup. The workspace:* protocol ensures that the local version of @storybook/builder-vite from this repository is used. Pinning to 0.1.22 will instead fetch a very old, published version from the registry, which is a significant downgrade from the current workspace version (8.3.0-beta.3). This will likely break the build or lead to unexpected behavior by using an incompatible, outdated version of the builder. The security vulnerability should be addressed within the @storybook/builder-vite package itself, not by breaking the workspace linkage.
| "@storybook/builder-vite": "0.1.22", | |
| "@storybook/builder-vite": "workspace:*", |
Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
code/frameworks/vue3-vite/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-QS-15268416
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Allocation of Resources Without Limits or Throttling